[TASK] Clean up various test scenarios #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes unused imports, and additional magic within the main "IntegrationTest" to make use of TYPO3's Testing Framework API as much as possible. The last tests need proper changes within the actual code base to remove direct dependencies to TSFE. Other parts have been moved to the respective test classes in order to reduce legacy code functionality.
dkd-kaehm
reviewed
May 16, 2023
Tests/Integration/Domain/Search/ResultSet/SearchResultSetServiceTest.php
Outdated
Show resolved
Hide resolved
dkd-kaehm
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
This change removes unused imports, and additional magic within the main "IntegrationTest" to make use of TYPO3's
Testing Framework API as much as possible.
The last tests missing now need proper changes within the actual code base to remove direct dependencies to TSFE
to reduce further global state (see $GLOBALS['TSFE'] and $GLOBALS['TYPO3_REQUEST'] usages in Tests/Integration).
Other parts have been moved to the respective test classes in order to reduce legacy code functionality.