[BUGFIX] Handle float values in options facet parser #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-kaehm
requested changes
Jul 20, 2023
dkd-kaehm
approved these changes
Oct 12, 2023
68 tasks
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Oct 12, 2023
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Oct 12, 2023
dkd-kaehm
pushed a commit
that referenced
this pull request
Oct 13, 2023
dkd-kaehm
pushed a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Cast solr value to string to handle float values correctly.
When the result values are 0.01, 0.02, 0.03 the last count wins with the array key 0
see https://3v4l.org/2LOHk#v8.1.20
Version
Tested on dev-master with TYPO3 12.4.3
Maintainers notes:
Port: