[FEATURE] Introduce --dry-run option to commands #42
Conversation
There was a problem hiding this comment.
Hi, I would like to keep this PR as clean as possible. Additionally, this repo is already using the rules from "typo3/coding-standards". Applying further code styles, not listed in the mentioned rules, for a couple of files only, makes further maintenance unnecessary hard. Could you therefore please revert the code style changes?
gilbertsoft
force-pushed
the
feature/dry-run-option
branch
2 times, most recently
from
1b901d5
to
3f2af41
Compare
Done |
|
We should also adjust the README correspondingly. |
gilbertsoft
force-pushed
the
feature/dry-run-option
branch
from
3f2af41
to
e6c2b22
Compare
Agree but I'm currently not able to change it because there are too many problems which will get fixed automatically and deactivating the md linter extensions does not help :( |
| ->addOption('no-docs', '', InputOption::VALUE_OPTIONAL, 'Disable version update in documentation settings', false); | ||
| ->addOption('no-docs', '', InputOption::VALUE_OPTIONAL, 'Disable version update in documentation settings', false) | ||
| ->addOption('dry-run', null, InputOption::VALUE_NONE, 'Outputs the operations but will not execute anything') | ||
| ; |
| } catch (\InvalidArgumentException $e) { | ||
| $io->error(sprintf('An error occurred while setting the ext_emconf.php version to %s.', $version)); | ||
| return 1; | ||
| if (!$dryRun) { |
There was a problem hiding this comment.
Could we just do an early return above L:71? There is nothing to do below, in case this is a dry run. Would make the change a bit smaller.
There was a problem hiding this comment.
I've added a note here and below. If we like to keep this output, no.
Handled with #48. Afterwards I'm able to add the dry-run option. |
gilbertsoft
force-pushed
the
feature/dry-run-option
branch
from
e6c2b22
to
523a344
Compare
| @@ -68,6 +70,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| ->setRaw($input->getOption('raw') !== false) | |||
| ->setDefaultAuthMethod($this->defaultAuthMethod); | |||
|
|
|||
| // In case of a dry-run the request to TER is skipped. | |||
| if ($input->getOption('dry-run') === true) { | |||
| $io->note(sprintf('Would have sent the command "%s %s", skipping', $requestConfiguration->getMethod(), $requestConfiguration->getEndpoint())); | |||
There was a problem hiding this comment.
Maybe we should output the command name instead, not sure....
Resolves #40