Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page parameter for specific highlighting #162

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

file098
Copy link

@file098 file098 commented Dec 2, 2024

This pull request includes several changes to the TextLayer.vue file to improve the readability and functionality of the text layer component in the Vue PDF project. The most important changes include the addition of a new prop for highlighting specific pages, refactoring of the code for better readability, and updating the event handling for text highlighting and text loading.

Improvements to functionality:

  • Added a new prop hightlightPages to allow highlighting specific pages.

Code readability and consistency:

  • Changed single quotes to double quotes for consistency in import statements and other string literals.
  • Refactored the findAndHighlight function to include the new hightlightPages prop and improve readability.
  • Updated the render function to streamline the creation and appending of the end-of-content div.
  • Simplified onMouseDown and onMouseUp event handlers to improve code clarity.

@TaTo30 TaTo30 linked an issue Dec 2, 2024 that may be closed by this pull request
@TaTo30 TaTo30 merged commit d2349f0 into TaTo30:master Dec 2, 2024
@TaTo30
Copy link
Owner

TaTo30 commented Dec 2, 2024

Looks good, thank you!

It will be released in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page parameter for highlight
2 participants