fix: check for undefined ref value in usePDF #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this awesome package!
For my current project I don't have the URL of a PDF at component-setup. However, I have to make the call to usePDF since it internally uses stuff that can only be used during component setup.
When providing a ref that has no initial value its value will be
undefined, which leads to errors because PDFJS does not expectundefinedas thegetDocumentparameter. This PR adds checks for undefined and only runs theprocessLoadingTaskif the ref value is notundefined.Through the watcher action the PDF will be loaded once the ref value has been set.
If you have any questions please tag me 😄