Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double width chars #92

Closed
wants to merge 4 commits into from
Closed

Conversation

wavexx
Copy link
Member

@wavexx wavexx commented Jan 31, 2015

It works, and should fix #54, but with an atrocious performance hit.

@wavexx wavexx force-pushed the double_width_chars branch from b892780 to f7c56c4 Compare January 31, 2015 14:03
@wavexx
Copy link
Member Author

wavexx commented Jan 31, 2015

Rebased on current master, though column_xw seems to return broken values since the last time I tried the branch, resulting in crashes.

@wavexx
Copy link
Member Author

wavexx commented Jan 31, 2015

I'm not sure why travis fails here. The tests run on my machine, except for python 2.7 (for which I see there's no support yet).

@wavexx
Copy link
Member Author

wavexx commented Jan 31, 2015

If we merge this, calculation of column widths should probably also consider double-width chars(!).

@firecat53
Copy link
Collaborator

I fixed the python 2 unittest...it was a stupid mistake. I rebased onto master with the fixed test and fixed support for command line object (list of lists) display. The tests all pass locally.

Some timing runs with a relatively big (280M) file didn't seem to show any significant difference between current master and this branch.

I haven't had a chance to work on adding in the double-width consideration in column width calculations yet.

Pushed to wavexx-double_width_chars branch.

@firecat53
Copy link
Collaborator

I think I'm going to merge this as-is and then open a separate issue for considering double-width characters in the column width calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Unicode support
2 participants