refactor(agent&vscode): connect vscode extension to agent via lsp. #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icycodes
force-pushed
the
refactor-agent-vscode-lsp
branch
from
c2623b5 to
76cb653
Compare
icycodes
commented
May 27, 2024
| this.config.on("updatedServerConfig", () => { | ||
| console.log("updatedServerConfig", { config: this.config.server }); | ||
| webviewView.webview.html = this._getWebviewContent(this.config.server); | ||
| }); |
There was a problem hiding this comment.
@wwayne I added a listener for changes of server config.
There was a problem hiding this comment.
not sure if will affect other stuff like theme syncing, I will do more testing after merge
| return ` | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <!--hash: ${hashObject(server)}--> |
There was a problem hiding this comment.
@wwayne I added this hash for force refreshing when server config did change.
| // We don't include DOM types in typescript building config | ||
|
|
||
| // FIXME: This is required by `@quilted/threads` and `tabby-chat-panel` | ||
| declare type HTMLIFrameElement = unknown; |
There was a problem hiding this comment.
@wwayne I remove DOM types dependencies in this refactor. But HTMLIFrameElement is used by @quilted/threads and tabby-chat-panel. Added this dummy declaration for tsc checks.
icycodes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: