Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): register with name #2248

Merged
merged 4 commits into from
May 27, 2024
Merged

feat(ui): register with name #2248

merged 4 commits into from
May 27, 2024

Conversation

wwayne
Copy link
Contributor

@wwayne wwayne commented May 27, 2024

Register with name

  • The name field is required
123 2

Testing

  • Admin register with name
  • Member register with invitationCode & name

@wwayne wwayne requested a review from wsxiaoys May 27, 2024 04:56

This comment was marked as outdated.

@wwayne wwayne marked this pull request as draft May 27, 2024 05:34
@@ -834,6 +834,7 @@ impl Mutation {
password1: String,
password2: String,
invitation_code: Option<String>,
name: Option<String>
Copy link
Member

@wsxiaoys wsxiaoys May 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Option<String>
name: String

You can put Some(name) in line 848, since you're making it required in FE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.42%. Comparing base (4d3a76c) to head (7b9bd0f).
Report is 1 commits behind head on main.

Files Patch % Lines
ee/tabby-schema/src/schema/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
+ Coverage   53.37%   53.42%   +0.04%     
==========================================
  Files         163      163              
  Lines       14581    14595      +14     
==========================================
+ Hits         7783     7797      +14     
  Misses       6798     6798              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wwayne wwayne marked this pull request as ready for review May 27, 2024 06:34
@wsxiaoys wsxiaoys merged commit 8c956b9 into main May 27, 2024
10 checks passed
@wsxiaoys wsxiaoys deleted the register-with-name branch May 27, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants