-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): register with name #2248
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ee/tabby-schema/src/schema/mod.rs
Outdated
@@ -834,6 +834,7 @@ impl Mutation { | |||
password1: String, | |||
password2: String, | |||
invitation_code: Option<String>, | |||
name: Option<String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Option<String> | |
name: String |
You can put Some(name)
in line 848, since you're making it required
in FE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
+ Coverage 53.37% 53.42% +0.04%
==========================================
Files 163 163
Lines 14581 14595 +14
==========================================
+ Hits 7783 7797 +14
Misses 6798 6798 ☔ View full report in Codecov by Sentry. |
Register with name
name
field is requiredTesting