feat(chat-ui): add smart apply to chat panel #3112

Sma1lboy · 2024-09-10T16:29:49Z

Demo (last update: 10/17/2024):

Screen.Recording.2024-10-17.at.03.19.27.mov

Three general way using smart apply

adding tests
adding comments
insert similar code

Steps

Implement a smart apply button in the chat view
Use fuzzy search to get line range for insertion or replacement
If fuzzy search cannot find an appropriate line range, use the Tabby backend to prompt for a range to insert
Refactor chat useful functions
Refactor Workspace operation requests into WorkspaceFeature in VSCode
Keep provideSmartApplyEdit, consider still using it in situations where the current smartApply is not working
Change the prompt for provideSmartApplyLineRange for the Tabby backend

a

…nction add provideSmartApplyLineRange functionality to TabbyAgent and ChatEditProvider a

add ChatFeature to ChatViewProvider for smart apply functionality

clients/tabby-chat-panel/src/index.ts

…onents, adding smart bool to on apply edit

…ply prompt

q

…nge.undefined

fix(vscode): correct comment for line number range in ChatViewProviderundefined

…Requestundefined

also adding default data config fix: remove test

…ands.ts and extension.ts files.

…eature.

…ching.

…nclude additional parameters.

- move some chat status to chat global - move smart apply function to smart apply feature - update prompt

…rotocol params

…ions, also remove indent param

…uzzy matching

…ionality.

…chat feature

…nge function.

…n and logger updates.

clients/tabby-agent/src/protocol.ts

clients/tabby-agent/src/config/default.ts

clients/vscode/src/lsp/WorkspaceFeature.ts

icycodes · 2024-10-24T02:31:17Z

@Sma1lboy, could you please rebase this pull request on the main branch and resolve conflicts?

clients/vscode/src/lsp/WorkspaceFeature.ts

Sma1lboy · 2024-10-24T03:56:21Z

@Sma1lboy, could you please rebase this pull request on the main branch and resolve conflicts?

Hi @icycodes, I just rebased the code.

…rompt

icycodes · 2024-10-25T15:35:36Z

Hi @Sma1lboy, I have created a PR at Sma1lboy#2 that makes some updates to the code style. Please check it out. Thank you.

fix: update code style for pr 3113.

Sma1lboy added 7 commits September 10, 2024 11:29

feat(chat-ui): add smart apply functionality to chat panel

7a7b3ed

to: smart apply in editor also pass language id

4b848cc

a

feat(tabby-agent): adding providing best fit range for smart apply fu…

6241339

…nction add provideSmartApplyLineRange functionality to TabbyAgent and ChatEditProvider a

to(vscode): request fit line range

b2a370a

add ChatFeature to ChatViewProvider for smart apply functionality

feat: add onSmartApplyInEditor function to ChatSideBar component

9e6d1ca

to(tabby-agent): adding provideSmartApplyRequest base on chatEdit

7360a15

feat(vscode): add smart apply functionality to ChatViewProvider

f4f91a2

wsxiaoys reviewed Sep 12, 2024

View reviewed changes

clients/tabby-chat-panel/src/index.ts Outdated Show resolved Hide resolved

Sma1lboy added 8 commits September 12, 2024 11:56

feat: remove onSmartApplyInEditor from ChatPanel and ChatSideBar comp…

36424d1

…onents, adding smart bool to on apply edit

feat(tabby-agent): add smart apply functionality to generate-smart-ap…

331d0d4

…ply prompt

Merge branch 'main' into feat-smart-apply

4946bec

q

refactor: Update parameter options in TabbyAgent.ts to include lineRa…

7490a0d

…nge.undefined

feat: add support for indentInfo in SmartApplyCodeParams.undefined

f032434

docs: update smart apply instructions with indentation details.undefined

69e67e7

fix(tabby-agent): update documentation and remove unused imports

d5d845f

fix(vscode): correct comment for line number range in ChatViewProviderundefined

chore: remove unnecessary prompt filesundefined

1643079

Sma1lboy marked this pull request as ready for review September 19, 2024 00:49

fix(lsp): add cancellation token handling for ChatLineRangeSmartApply…

5d11479

…Requestundefined

Sma1lboy requested a review from wsxiaoys September 24, 2024 02:05

Merge branch 'main' into origin-feat-smart-apply

7405d54

Sma1lboy force-pushed the feat-smart-apply branch from c4428c0 to 27c3677 Compare September 26, 2024 07:34

rebase: rebase chat web view client api to webviewhelper

55220c3

also adding default data config fix: remove test

Sma1lboy force-pushed the feat-smart-apply branch from 27c3677 to 55220c3 Compare September 26, 2024 07:38

Sma1lboy added 7 commits September 26, 2024 02:47

fix(ui): add support for wrapping long lines in CodeBlock component

bd06cbd

Merge branch 'main' into feat-smart-apply

9b1553d

refactor: update chatPanelViewProvider constructor parameters in Comm…

8f8b94d

…ands.ts and extension.ts files.

refactor: Update imports and remove unused code in chat inline edit f…

94aeb37

…eature.

feat: add fuzzyApplyRange function for applying ranges with fuzzy mat…

a3744a1

…ching.

refactor(Commands): Modify the creation of ChatPanelViewProvider to i…

ef3e35b

…nclude additional parameters.

refactor(chat): add SmartApplyFeature to the chat functionality.

d630c6a

- move some chat status to chat global - move smart apply function to smart apply feature - update prompt

Sma1lboy added 13 commits October 13, 2024 00:54

refactor(chat): remove smart apply code

7b8e1f3

refactor(vscode): remove provide line range method, also update new p…

a2c6531

…rotocol params

refactor: rename fuzzyApplyRange.ts to SmartRange.ts and update funct…

8734ae9

…ions, also remove indent param

refactor(chat): update SmartApplyFeature to handle apply range with f…

b1b964f

…uzzy matching

refactor: update chat feature to include revealing editor range funct…

22fafad

…ionality.

refactor(client): remove global chat status

798b173

refactor(vscode): separate the workspace lsp server request from the …

90b5354

…chat feature

chore: remove unused logger

a8d4ee6

Merge branch 'main' into feat-smart-apply

ff177df

refactor(smart-apply): still using diff llms to apply code

df05e27

docs: add comments for explaining the return value of getSmartApplyRa…

88db1bc

…nge function.

refactor(chat): refactor SmartApply.ts with revealEditorRange functio…

645ed2f

…n and logger updates.

chore: update code insertion guidelines.

905df91

wsxiaoys requested a review from icycodes October 21, 2024 02:34

icycodes reviewed Oct 21, 2024

View reviewed changes

clients/tabby-agent/src/protocol.ts Outdated Show resolved Hide resolved

clients/tabby-agent/src/config/default.ts Outdated Show resolved Hide resolved

clients/vscode/src/lsp/WorkspaceFeature.ts Outdated Show resolved Hide resolved

Sma1lboy added 3 commits October 21, 2024 19:42

chore: remove RevealEditorRangeRequest and using existing LSP API

5ee4490

chore: move smartApply to single section

58fc87e

chore: remove unused dynamic feature interface

dd7f007

icycodes reviewed Oct 24, 2024

View reviewed changes

clients/vscode/src/lsp/WorkspaceFeature.ts Outdated Show resolved Hide resolved

Sma1lboy added 2 commits October 23, 2024 22:40

chore: remove lsp client ShowDocRequest implementation

30cd9f8

Merge branch 'main' into feat-smart-apply

a39a4d9

Sma1lboy and others added 3 commits October 25, 2024 03:15

chore: adding rule avoid generate \n for first line for smart apply p…

ab3843e

…rompt

fix: update code style for pr 3112.

61d7bbd

fix(vscode): update smart apply api.

3d4e2bb

Merge pull request #2 from icycodes/fix-pr-3113-update-code-style

19d5609

fix: update code style for pr 3113.

icycodes merged commit 7656965 into TabbyML:main Oct 26, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(chat-ui): add smart apply to chat panel #3112

feat(chat-ui): add smart apply to chat panel #3112

Sma1lboy commented Sep 10, 2024 •

edited

Loading

icycodes commented Oct 24, 2024

Sma1lboy commented Oct 24, 2024

icycodes commented Oct 25, 2024

feat(chat-ui): add smart apply to chat panel #3112

feat(chat-ui): add smart apply to chat panel #3112

Conversation

Sma1lboy commented Sep 10, 2024 • edited Loading

Demo (last update: 10/17/2024):

Steps

icycodes commented Oct 24, 2024

Sma1lboy commented Oct 24, 2024

icycodes commented Oct 25, 2024

Sma1lboy commented Sep 10, 2024 •

edited

Loading