Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Kotlin language #813

Merged
merged 25 commits into from
Nov 23, 2023
Merged

feat: add support for Kotlin language #813

merged 25 commits into from
Nov 23, 2023

Conversation

sonique6784
Copy link
Contributor

Added support for Kotlin language

wsxiaoys
wsxiaoys requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the ci

@wsxiaoys wsxiaoys marked this pull request as draft November 17, 2023 19:33
@sonique6784 sonique6784 changed the title Added suport for Kotlin language Added support for Kotlin language Nov 18, 2023
@sonique6784 sonique6784 force-pushed the feature/language-kotlin branch from 17cff26 to d46ee56 Compare November 18, 2023 01:22
@sonique6784 sonique6784 force-pushed the feature/language-kotlin branch from d46ee56 to 82ca14a Compare November 18, 2023 02:41
@sonique6784 sonique6784 changed the title Added support for Kotlin language feat: add support for Kotlin language Nov 18, 2023
@wsxiaoys wsxiaoys marked this pull request as ready for review November 18, 2023 04:24
@wsxiaoys wsxiaoys marked this pull request as draft November 18, 2023 08:01
sonique6784 and others added 18 commits November 18, 2023 21:02
@sonique6784
fix: kotlin missing TAGGING_QUERY
a593b66
@wsxiaoys @sonique6784
docs: remove 0.5.0 warning as tabby adapt same format for remote / lo…
d3be178 
…cal storage
@wsxiaoys @sonique6784
feat: make --model optional, so user can start a chat only instance (T…
2b41dc1 
…abbyML#817)
@wsxiaoys @sonique6784
fix: mark tabby-ui as yarn managed
cae8e5a
@wsxiaoys @sonique6784
fix: rust build caused by 1.74.0 release (TabbyML#819)
e3bd652
@wsxiaoys @sonique6784
chore: exclude experimental directory for language stats
9d0f449
@wsxiaoys @sonique6784
chore: exclude ee/tabby-webserver/ui to language stats
f295517
@darknight @sonique6784
fix: move db path, fix compile error (TabbyML#820)
15e130c
@icycodes @sonique6784
feat(vscode): Add dont-show-again for warnings. Add online help links. (
400a5c1 
TabbyML#821)
@wsxiaoys @sonique6784
refactor: delete contrib/jetson/Dockerfile as it's no longer compatib…
7dfd139 
…le post 0.5

feel free to sending pr of adding it back if you get it work with llama.cpp based docker image
@icycodes @sonique6784
feat(vim): update tabby-agent. (TabbyML#824)
9121763
@icycodes @sonique6784
feat(intellij): Add dont-show-again for warnings. Add more online hel…
79a41c9 
…p links. (TabbyML#823)
@wsxiaoys @sonique6784
feat: implement basic dependency detection for python / rust (TabbyML…
fa7e565 
…#825)

* refactor: extract tags mod for dataset.rs

* feat: implement basic dependency detection for python / rust
@wsxiaoys @sonique6784
fix: keep only direct dependency, clean up path (TabbyML#827)
a17258e
@sonique6784
feat: add support for Kotlin
df86b0c
@wsxiaoys @sonique6784
Update Cargo.toml
444eee5
@sonique6784
fix: adjustment post rebase
4acf2f3
@sonique6784
Merge branch 'main' into feature/language-kotlin
91f390c
@sonique6784
Copy link
Contributor Author

I rebased and move the kotlin lang to tags.rs,
I ran make fix and cargo test --bin tabby --lib both are successful

ready for review

@sonique6784 sonique6784 marked this pull request as ready for review November 18, 2023 11:44
@sonique6784 sonique6784 requested a review from wsxiaoys November 19, 2023 07:23
@wsxiaoys wsxiaoys marked this pull request as draft November 20, 2023 01:01
@erfanium erfanium mentioned this pull request Nov 20, 2023
Closed
@sonique6784 sonique6784 requested a review from wsxiaoys November 21, 2023 05:28
@wsxiaoys wsxiaoys mentioned this pull request Nov 21, 2023
Merged
@sonique6784 sonique6784 marked this pull request as ready for review November 22, 2023 03:18
wsxiaoys
wsxiaoys reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

sonique6784 and others added 2 commits November 23, 2023 08:24
@sonique6784 @wsxiaoys
remove definition import
648b06e 
Co-authored-by: Meng Zhang <meng@tabbyml.com>
@sonique6784 @wsxiaoys
remove typealias
d79b607 
Co-authored-by: Meng Zhang <meng@tabbyml.com>
@sonique6784 sonique6784 requested a review from wsxiaoys November 22, 2023 21:26
@wsxiaoys wsxiaoys merged commit b9cb5a0 into TabbyML:main Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsxiaoys wsxiaoys Awaiting requested review from wsxiaoys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sonique6784 @wsxiaoys @darknight @icycodes