Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoSuchMethodError in ItemBuilder#getSkinValue #425

Merged
merged 4 commits into from
May 12, 2024

Conversation

Condordito
Copy link
Contributor

@Condordito Condordito commented May 7, 2024

#421 reintroduces this bug by using Authlib directly instead of relying on XSkull#getSkinValue

Screenshot 2024-05-07 at 12 06 46 AM

These changes match XSeries' SkullUtils class to handle both versions

@Condordito Condordito force-pushed the HeadTexture branch 2 times, most recently from 11140f4 to f49c5af Compare May 7, 2024 17:39
@Condordito Condordito marked this pull request as draft May 10, 2024 02:41
It hasn't been tested using paper 1.20.5 yet
@Condordito Condordito marked this pull request as ready for review May 10, 2024 04:12
@Bkm016
Copy link
Collaborator

Bkm016 commented May 11, 2024

这什么情况,一个逼头工具删了有加加了又删。

@Bkm016
Copy link
Collaborator

Bkm016 commented May 11, 2024

#422
@xiaozhangup

@Bkm016
Copy link
Collaborator

Bkm016 commented May 11, 2024

这个脑残工具到底应该怎么做

@Condordito
Copy link
Contributor Author

Condordito commented May 11, 2024

It should now work as intended. It doesn't use a fixed UUID but caches its GameProfile to be reused in subsequent calls

@xiaozhangup
Copy link
Contributor

xiaozhangup commented May 12, 2024

#422 @xiaozhangup

我今天下午来测测看这个问题,以及看看我之前提到的问题还在不在]。

@Condordito
Copy link
Contributor Author

Screen Recording 2024-05-12 at 1 05 02 AM

@xiaozhangup
Copy link
Contributor

@Bkm016 测了测没有我之前发现的问题
89f50c8a98949cbc8a921bcd07a18b7e

In v1.20.2 there were some changes to the mojang API.
Before that version both UUID and name fields couldn't be null, only one of them.
@Bkm016
Copy link
Collaborator

Bkm016 commented May 12, 2024

牛逼 哥

@Bkm016 Bkm016 merged commit 27c4e8e into TabooLib:master May 12, 2024
2 checks passed
@Condordito Condordito deleted the HeadTexture branch May 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants