-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NoSuchMethodError in ItemBuilder#getSkinValue #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Condordito
force-pushed
the
HeadTexture
branch
2 times, most recently
from
May 7, 2024 17:39
11140f4
to
f49c5af
Compare
It hasn't been tested using paper 1.20.5 yet
这什么情况,一个逼头工具删了有加加了又删。 |
这个脑残工具到底应该怎么做 |
It should now work as intended. It doesn't use a fixed UUID but caches its GameProfile to be reused in subsequent calls |
我今天下午来测测看这个问题,以及看看我之前提到的问题还在不在]。 |
@Bkm016 测了测没有我之前发现的问题 |
In v1.20.2 there were some changes to the mojang API. Before that version both UUID and name fields couldn't be null, only one of them.
牛逼 哥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#421 reintroduces this bug by using Authlib directly instead of relying on XSkull#getSkinValue
These changes match XSeries' SkullUtils class to handle both versions