[Feature Request]: Double click on a tag to open "Edit Tag" window

[Bamowen]

Checklist

• I am using an up-to-date version.
• I have read the documentation.
• I have searched existing issues.

Description

In the Library Tag you currently need to right click > Edit to open the "Edit Tag" window, which is not very intuitive.

Solution

It would be practical to have the option to open this "Edit Tag" window by double clicking on the desired Tag in the Library Tag.

Alternatives

No response

[mashed5894]

Hello! I took a quick look at this and it doesn't really seem like QPushButton is made for this purpose, and adding a double click timer might introduce some annoying delay into the normal functionality. An alternative solution might be to simply add an tiny edit button in the same style as the remove button.

[Bamowen]

If indeed the double click is not the most elegant way to do it, adding a small button to open an edit button sounds fine.
Main point is to not hide this feature in a context menu (only), but have the option to quickly get to it :)

[Computerdores]

@mashed5894 have you looked at QWidget.mouseDoubleClickEvent?

[rsazra]

Is there any reason a single click can't open the edit tag window? Clicking a tag just doesn't do anything right now, so why not add functionality to the regular, base interaction?

[mashed5894]

Is there any reason a single click can't open the edit tag window? Clicking a tag just doesn't do anything right now, so why not add functionality to the regular, base interaction?

It would make sense since the TagBox already does this, and it would feel bad from a ui design standpoint to make the same element have different behavior based on context.
One issue is that the tag library currently uses the same TagWidget as the preview TagBoxWidget, the TagSearchPanel, and the BuildTagPanel, and the widget itself is kind of a mess. We have both a on_click and on_edit signal, but sometimes if the TagClickActionOption is set to OPEN_EDIT they will both be effectively the same, but only the TagBox respects that setting. I think these should actually be divided up into two different widgets, one for the normal view (which edits on click), and another widget for selecting tags from a list (without editing on removing anything).

[Computerdores]

Is there any reason a single click can't open the edit tag window? Clicking a tag just doesn't do anything right now, so why not add functionality to the regular, base interaction?

What version are you on? Clicking a tag should open the Edit Tag modal (which it indeed does for me on the latest git)

Edit: Misunderstanding, it worked for me in the preview panel

[rsazra]

What version are you on? Clicking a tag should open the Edit Tag modal (which it indeed does for me on the latest git)

Hm, I just pulled the latest and it still doesn't open the modal on single click.

Just to make sure we're on the same page, I'm talking about clicking tags while in the "Library Tags" modal (opened with Cmd + M). I see that clicking the tags on a file does open the editor though.

And this is on macOS by the way, could that be the discrepancy?

[CyanVoxel]

I was also under the impression that left-clicking the tag from the Library Tags window would open the edit modal, but apparently not (also on macOS). I agree that the behavior should be consistent in this case

[Computerdores]

I only tested in the preview panel, I was under the impression that the widgets are the exact same, oops