[Feature Request]: Use sql to delete all unlinked entries simultaneously #617
Labels
Priority: Low
Doesn't require immediate attention
TagStudio: Library
Relating to the TagStudio library system
Type: Enhancement
New feature or request
Type: QoL
A quality of life (QoL) enhancement or suggestion
Comments
Toby222
added a commit
to Toby222/TagStudio
that referenced
this issue
Nov 30, 2024
This technically removes the usefulness progress indicator, but brief testing on my end had it delete ~8000 entries in less time than it took me to see if the progress indicator was properly indeterminate or not
CyanVoxel
added
Type: QoL
CyanVoxel
pushed a commit
that referenced
this issue
Jan 11, 2025
* feat: Delete all unlinked entries at once (#617) This technically removes the usefulness progress indicator, but brief testing on my end had it delete ~8000 entries in less time than it took me to see if the progress indicator was properly indeterminate or not * fix(fmt): remove unused import * fix: wasn't able to delete more than 32766 entries * chose: ruff check --fix * fix: address review comment --------- Co-authored-by: Tobias Berger <toby@tobot.dev>
github-project-automation
bot
moved this from 🚧 In progress
to ✅ Done
in TagStudio Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Description
As per this TODO:
Currently when deleting unlinked entries, they are deleted one-by-one, only so they can update the progress bar.
I believe it would be better to let the progress bar be indeterminate and speed up the deletion by deleting all items in parallel.
In brief testing the speedup was significant enough that the progress bar was no longer visible long enough for the lack of visible progress to matter :^)
Solution
Instead of calling
remove_entrieswith one id at a time, pass all relevant IDs simultaneously.Alternatives
No response
The text was updated successfully, but these errors were encountered: