Drag and drop files in and out of TagStudio #153

Creepler13 · 2024-05-09T22:56:03Z

Added the ability to drop files into TagStudio, which adds them to the library

A popup will ask how to resume when some/all of the files names already exist in the librarys root folder

Skip
Override
Rename
Cancel

I put it in the modal folder because i plan/ned to add a window that allows you to import files from discord, google, etc
since these are links and they need extra logic to either download or safe them as text.

I used the method described in #75

Edit: Dragging out of TagStudio was added

tagstudio/src/qt/modals/drop_import.py

yedpodtrzitko · 2024-05-10T15:30:17Z

doesnt work for me:

Traceback (most recent call last):
  File "/Users/yed/dev/python/TagStudio/tagstudio/tag_studio.py", line 9, in <module>
    from src.qt.ts_qt import QtDriver
  File "/Users/yed/dev/python/TagStudio/tagstudio/src/qt/ts_qt.py", line 85, in <module>
    from src.qt.modals import (
  File "/Users/yed/dev/python/TagStudio/tagstudio/src/qt/modals/drop_import.py", line 30
    f"The files  {", ".join(map(lambda url:url.fileName(),duplicate_filesnames))}  have filenames that already exist in the library folder."
                   ^
SyntaxError: f-string: expecting '}'

Seems like using double quotes inside the same quotes isnt supported in Python 3.10. Could be easy to fix it to keep the compatibility with that version.

tagstudio/src/qt/modals/drop_import.py

yedpodtrzitko · 2024-05-10T15:38:30Z

beside the error it works as expected, nice job.

tagstudio/src/qt/modals/drop_import.py

Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com>

Creepler13 · 2024-05-12T00:31:42Z

Forgot about folders. They work now

tagstudio/src/qt/modals/drop_import.py

Creepler13 · 2024-05-12T13:57:59Z

Added progress bars, helpfull especially for large amounts of or large files

Creepler13 · 2024-05-22T17:53:30Z

Added drag out of window support

#75

CyanVoxel · 2024-05-24T00:38:35Z

i give up, no more formatting

I'll take a look at it, I've been fighting with the MyPy stuff myself

tagstudio/src/qt/modals/drop_import.py

CyanVoxel · 2024-06-13T17:58:49Z

I apologize for the delay on getting this pulled. Thank you for all your work on this!

* Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com>

* Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com>

* Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com>

* Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms * Fix ruff formatting --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com>

* Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms * Fix ruff formatting * Rename "override" button to "overwrite" --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com>

* feat: Drag and drop files in and out of TagStudio (#153) * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms * Fix ruff formatting * Rename "override" button to "overwrite" --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * refactor: Update dialog and simplify drop import logic * Handle Qt events for main window in ts_qt.py * Replace magic values with enums * Match import duplicate file dialog to delete missing entry dialog * Remove excessive progess widgets * Add docstrings and logging * refactor: add function for common ProgressWidget use Extracts the create_progress_bar function from drop_import to the ProgressWidget class. Instead of creating a ProgressWidget, FunctionIterator, and CustomRunnable every time a thread-safe progress widget is needed, the from_iterable function in ProgressWidget now handles all of that. --------- Co-authored-by: Creepler13 <denis.schlichting03@gmail.com> Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com>

…ev#528) * feat: Drag and drop files in and out of TagStudio (TagStudioDev#153) * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * Ability to drop local files in to TagStudio to add to library * Added renaming option to drop import * Improved readability and switched to pathLib * format * Apply suggestions from code review Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Revert Change * Update tagstudio/src/qt/modals/drop_import.py Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> * Added support for folders * formatting * Progress bars added * Added Ability to Drag out of window * f * format * format * formatting and refactor * format again * formatting for mypy * convert lambda to func for clarity * mypy fixes * fixed dragout only worked on selected * Refactor typo, Add license * Reformat QMessageBox * Disable drops when no library is open Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * Rebased onto SQL migration * Updated logic to based on selected grid_idx instead of selected ids * Add newly dragged-in files to SQL database * Fix buttons being inconsistant across platforms * Fix ruff formatting * Rename "override" button to "overwrite" --------- Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com> Co-authored-by: Sean Krueger <skrueger2270@gmail.com> * refactor: Update dialog and simplify drop import logic * Handle Qt events for main window in ts_qt.py * Replace magic values with enums * Match import duplicate file dialog to delete missing entry dialog * Remove excessive progess widgets * Add docstrings and logging * refactor: add function for common ProgressWidget use Extracts the create_progress_bar function from drop_import to the ProgressWidget class. Instead of creating a ProgressWidget, FunctionIterator, and CustomRunnable every time a thread-safe progress widget is needed, the from_iterable function in ProgressWidget now handles all of that. --------- Co-authored-by: Creepler13 <denis.schlichting03@gmail.com> Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com> Co-authored-by: Travis Abendshien <lvnvtravis@gmail.com>

Creepler13 added 2 commits May 10, 2024 00:23

Ability to drop local files in to TagStudio to add to library

dccf5f2

Added renaming option to drop import

44c6a96

CyanVoxel added this to the Alpha 9.3.x milestone May 10, 2024

CyanVoxel added the Type: Enhancement New feature or request label May 10, 2024

yedpodtrzitko reviewed May 10, 2024

View reviewed changes

tagstudio/src/qt/modals/drop_import.py Outdated Show resolved Hide resolved

tagstudio/src/qt/modals/drop_import.py Outdated Show resolved Hide resolved

Creepler13 added 2 commits May 10, 2024 16:38

Improved readability and switched to pathLib

95fe393

format

c3793d5

yedpodtrzitko reviewed May 10, 2024

View reviewed changes

tagstudio/src/qt/modals/drop_import.py Outdated Show resolved Hide resolved

yedpodtrzitko reviewed May 10, 2024

View reviewed changes

tagstudio/src/qt/modals/drop_import.py Outdated Show resolved Hide resolved

Creepler13 and others added 4 commits May 10, 2024 18:14

Apply suggestions from code review

f0cf853

Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com>

Merge branch 'TagStudioDev:main' into DropFiles

f7eaec7

Revert Change

e835a00

Update tagstudio/src/qt/modals/drop_import.py

741b2d6

Co-authored-by: yed podtrzitko <yedpodtrzitko@users.noreply.github.com>

yedpodtrzitko approved these changes May 10, 2024

View reviewed changes

Added support for folders

5149855

yedpodtrzitko reviewed May 12, 2024

View reviewed changes

tagstudio/src/qt/modals/drop_import.py Outdated Show resolved Hide resolved

Creepler13 added 2 commits May 12, 2024 13:57

formatting

12c4c43

Progress bars added

aeb119e

Creepler13 added 2 commits May 22, 2024 18:50

Added Ability to Drag out of window

dbbe1b0

f

9a45ae1

Creepler13 force-pushed the DropFiles branch from 27480bc to 9a45ae1 Compare May 22, 2024 17:23

format

1a70369

Creepler13 added 3 commits May 22, 2024 20:22

Ability to drop local files in to TagStudio to add to library

0ac25d6

Added renaming option to drop import

d7a9305

Improved readability and switched to pathLib

f9d1b55

yedpodtrzitko reviewed May 24, 2024

View reviewed changes

tagstudio/src/qt/modals/drop_import.py Outdated Show resolved Hide resolved

Creepler13 added 3 commits May 24, 2024 17:31

convert lambda to func for clarity

fb1c3a2

mypy fixes

dfbf31f

fixed dragout only worked on selected

45056f1

CyanVoxel self-assigned this Jun 13, 2024

CyanVoxel mentioned this pull request Jun 13, 2024

feat: drag-n-drop into other applications #283

Closed

CyanVoxel changed the base branch from main to Alpha-v9.4 June 13, 2024 17:13

CyanVoxel added 3 commits June 13, 2024 10:19

Refactor typo, Add license

301a7b0

Reformat QMessageBox

763d189

Disable drops when no library is open

9549d92

CyanVoxel merged commit e5a0e5a into TagStudioDev:Alpha-v9.4 Jun 13, 2024
3 checks passed

CyanVoxel mentioned this pull request Jun 13, 2024

[suggestion] drag and drop outside the window #75

Closed

Creepler13 deleted the DropFiles branch June 15, 2024 13:31

CyanVoxel mentioned this pull request Jul 28, 2024

[Feature Request]: Drag-n-drop "to" and "from" app #335

Closed

3 tasks

seakrueger mentioned this pull request Sep 28, 2024

feat: Reimplement drag drop files on sql migration #528

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drag and drop files in and out of TagStudio #153

Drag and drop files in and out of TagStudio #153

Creepler13 commented May 9, 2024 •

edited

Loading

yedpodtrzitko commented May 10, 2024 •

edited

Loading

yedpodtrzitko commented May 10, 2024

Creepler13 commented May 12, 2024

Creepler13 commented May 12, 2024

Creepler13 commented May 22, 2024

CyanVoxel commented May 24, 2024

CyanVoxel commented Jun 13, 2024

Drag and drop files in and out of TagStudio #153

Drag and drop files in and out of TagStudio #153

Conversation

Creepler13 commented May 9, 2024 • edited Loading

yedpodtrzitko commented May 10, 2024 • edited Loading

yedpodtrzitko commented May 10, 2024

Creepler13 commented May 12, 2024

Creepler13 commented May 12, 2024

Creepler13 commented May 22, 2024

CyanVoxel commented May 24, 2024

CyanVoxel commented Jun 13, 2024

Creepler13 commented May 9, 2024 •

edited

Loading

yedpodtrzitko commented May 10, 2024 •

edited

Loading