Separately pin QT nixpkg version #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seakrueger
force-pushed
the
pin-flake-deps
branch
from
2a781ce to
5d33f57
Compare
CyanVoxel
added
the
Type: Installation
seakrueger
force-pushed
the
pin-flake-deps
branch
from
5d33f57 to
7d648d2
Compare
|
Meant to respond to this earlier but I have been busy on vacation. I'm currently almost up to a stable NixOS setup so I can actually test this, on a glance though this seems great! |
Currently, this succesfully launches the program. Pinning qt seperatly allows the rest of unstable nixpkgs to be updated even after the qt package version has been bumped. This fixes vim failing to launch in the nix shell because of a bad gcc version. Bumping the package version to qt6.7.1 also will require bumping PySide to 6.7.1, otherwise it will fail to find qt. Qt 6.7.1 nixpkg commit is 47da0aee5616a063015f10ea593688646f2377e4
QtCreator was still against nixpkgs not the specific qt variant.
seakrueger
force-pushed
the
pin-flake-deps
branch
from
7d648d2 to
9e5ff13
Compare
|
Confirmed working on NixOS, able to manipulate and create libraries. This is currently hardcoded to x86_64 on Linux, but so was the original flake, and is out of the scope of just making this work. I will make my own PR to address that (and I also don't want to mess up #229). CC @CyanVoxel - ready to be merged |
xarvex
added
Priority: Medium
This was
linked to
issues
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By pinning QT separately, the rest of dependent nixpkgs can be updated without being affected by the current QT version in nixpkgs unstable. The nixpkg revision is also bumped, fixing an issue where vim would immediately segfault on launch in the nix dev shell. This is for QT version 6.6.3, for when #223 is merged, the nixpkg commit tied to QT will need to be bumped to commit 47da0aee5616a063015f10ea593688646f2377e4.
Also adds missing dependecies from the new video player.