Delete file in TagStudio #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
- swapped out `typing` to `collections.abc` - removed unnecessary `str()` conversion in `FileDeleterHelper` constructor and `set_filepath`
yedpodtrzitko
approved these changes
Jun 13, 2024
yedpodtrzitko
suggested changes
Jun 15, 2024
There was a problem hiding this comment.
pipeline seems failing due to problem mentioned in #293, needs to be run manually again
yedpodtrzitko
approved these changes
Jun 15, 2024
|
I apologize for the delay on getting to this PR. I was originally going to inform you of a one or two tweaks I'd like to have made to this before pulling and asking if it would be okay if I committed them directly myself, however I ended up realizing there were a few more extensions to this I'd like as well as discovering some edge cases that are requiring much more work than this PR probably bargained for. My intention now is to accept and pull this into a separate branch where I'll finish working on these changes and additions instead of hijacking your PR. Thank you so much for the work you've already done here! |
CyanVoxel
removed
Status: Review Needed
This was referenced Aug 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to delete files in the right click context menu
closes #269