Skip to content

Conversation

@Computerdores
Copy link
Collaborator

This Pull Request addresses 3 Bugs I found while using the gallery_dl-sidecar importing feature:

  1. Running macros on files that aren't in a subdirectory was broken (see 1d45701).
  2. For filename.jpg get_gdl_sidecar would try to load filename.json instead of filename.jpg.json, which is the default filename format used by gallery_dl (see a0562a8).
  3. add_generic_data_to_entry would create a second Content Tags Field if the existing Content Tags field was the first field, because an if-statement used > instead of >= (see fbd2244).

I didn't create an Issue first because I had already fixed these issues in order to use the autofill macro to import gdl sidecar files.

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request TagStudio: Library Relating to the TagStudio library system Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed labels Aug 27, 2024
@CyanVoxel CyanVoxel self-assigned this Aug 31, 2024
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up! I know this is an unfinished + undocumented feature, but it seems to be working back up to its old standard now. After the .lower() comment is resolved this should be good to go!

@CyanVoxel CyanVoxel added Status: Changes Requested Changes are quested to this and removed Status: Review Needed A review of this is needed labels Aug 31, 2024
Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Changes Requested Changes are quested to this labels Aug 31, 2024
@CyanVoxel CyanVoxel merged commit 85d62e6 into TagStudioDev:Alpha-v9.4 Sep 1, 2024
@Computerdores Computerdores deleted the sidecar_macro_fixes branch July 6, 2025 17:24
@Computerdores Computerdores moved this to ✅ Done in TagStudio Development Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low Doesn't require immediate attention Status: Mergeable The code is ready to be merged TagStudio: Library Relating to the TagStudio library system Type: Enhancement New feature or request

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants