fix: Do not create command prompt window on subprocess #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
seakrueger
force-pushed
the
silent-popen
branch
2 times, most recently
from
f076cdc to
b5b2ccf
Compare
CyanVoxel
reviewed
Sep 3, 2024
Comment on lines
+2
to
+9
| exclude = ["main_window.py", "home_ui.py", "resources.py", "resources_rc.py", "**/vendored/"] | ||
|
|
||
| [tool.mypy] | ||
| strict_optional = false | ||
| disable_error_code = ["union-attr", "annotation-unchecked", "import-untyped"] | ||
| explicit_package_bases = true | ||
| warn_unused_ignores = true | ||
| exclude = ['tests'] | ||
| exclude = ['tests', 'src/qt/helpers/vendored'] |
There was a problem hiding this comment.
Any reason why the ruff exclusion pattern for vendored is different than mypy's?
|
This seems to be working when building on Windows with PyInstaller 6.10.0 and testing with video previews and audio waveform previews. I don't see anything immediately wrong with this besides MyPy complaining about the vendored files, which might not be excluded correctly. Also for some reason the last 4 commits keep creeping forward since they say they were authored in the future 🤷♂️ |
CyanVoxel
removed
Status: Help Wanted
|
Pulling this now with some ignore comments on the affected files. Couldn't seem to get the folder to exclude either, but this will work for now. Thank you so much for getting a fix for this! |
CyanVoxel
removed
the
Priority: Critical
Patches files from abandoned libraries are located and updated in src/qt/helpers/vendored with modified sections labeld PATCHED. A wrapper around subprocess.Popen automatically sets the creation flag to no window on windows.
CarterPillow
pushed a commit
to CarterPillow/TagStudio
that referenced
this pull request
Sep 7, 2024
) * fix: Do not create command prompt window on subcmd Patches files from abandoned libraries are located and updated in src/qt/helpers/vendored with modified sections labeld PATCHED. A wrapper around subprocess.Popen automatically sets the creation flag to no window on windows. * fix: Replace Popen in mediainfo_json decoder * fixup: Pipe stdin to stdin * chore: Exclude vendored dir from tooling checks * suppress mypy warnings
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches files from abandoned libraries are located and updated in src/qt/helpers/vendored with modified sections labeled PATCHED. A wrapper around subprocess.Popen automatically sets the creation flag to no window on windows.
Must be run via a pyinstaller executable for problem to occur.