-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations #447
base: main
Are you sure you want to change the base?
Translations #447
Conversation
Strings separated in #507
Any thoughts? @Tyrannicodin how much is left for this to be a proper PR and not a draft? |
The only missing thing is replacing all strings with translation functions, which I want to do in this pr or else it won't really add much. |
en.json |
Hmm, I'm not sure we need to translate logs right? They're not user-facing after all. |
Definitely lower priority, but I'm in favor of translating everything. Completely fine with just removing them as you see fit. I do not have enough knowledge of the code base (or code in general for that matter) to decide for myself what is user facing and what's not |
Just wanted to bump this and check if this is still being worked on. Translations are being pulled from webplate, so the sooner we can implement those, the better. Thanks! |
Adds a translator that handles translation of objects via QCoreApplication.translate(context, key), and translations are stored as .ini files in the format:
*context*.*key*="*Translation*"
Currently has very few actually translated components, just the structure to add more.