feat: add svg thumbnail support (port #442) #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tyrannicodin <86689800+Tyrannicodin@users.noreply.github.com>
CyanVoxel
added
Type: Enhancement
| # Create an svg renderer, then render to the painter | ||
| svg: QSvgRenderer = QSvgRenderer(str(filepath)) | ||
|
|
||
| if svg.isValid(): |
Contributor
There was a problem hiding this comment.
it would be nice to flip the logic here like:
if not svg.isValid():
raise UnidentifiedImageError
# same code as originally except not indented
Contributor
|
something something test :) b1bae1f |
Co-Authored-By: yed <yedpodtrzitko@users.noreply.github.com>
Member
Author
|
The test here may result in a similar issue experienced here: #543 (comment) |
yedpodtrzitko
approved these changes
Oct 13, 2024
Contributor
yedpodtrzitko
left a comment
yedpodtrzitko
left a comment
There was a problem hiding this comment.
dont forget to squash the commits :)
Closed
CyanVoxel
removed
Priority: Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a port of #442 which previously targeted thumbnails/Alpha-v9.4 to main (aka v9.5x).
This adds thumbnail/preview support for SVG files.