Skip to content

Conversation

@KirilBourakov
Copy link
Contributor

@KirilBourakov KirilBourakov commented Nov 24, 2024

Fixed normpath variable using posix, leading to windows not understanding the command given to it (issue #602)

@KirilBourakov KirilBourakov changed the title Fixed open in explorer does not open the correct folder #602 Fixed open in explorer does not open the correct folder Nov 24, 2024
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended TagStudio: Library Relating to the TagStudio library system Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed Type: File System File system interactions labels Nov 24, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Nov 24, 2024
@CyanVoxel CyanVoxel linked an issue Nov 24, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me and looks good

@Computerdores Computerdores added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Nov 29, 2024
@CyanVoxel CyanVoxel merged commit d152cd7 into TagStudioDev:main Nov 29, 2024
5 checks passed
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Nov 29, 2024
yedpodtrzitko pushed a commit to yedpodtrzitko/TagStudio that referenced this pull request Nov 30, 2024
* replaced as_posix with str

* replaced addition with f string

---------

Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium An issue that shouldn't be be saved for last TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended Type: File System File system interactions

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Open in explorer does not open the correct folder

3 participants