-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve relink performance #614
base: main
Are you sure you want to change the base?
Conversation
Not sure if this is intended to be ready or not, but I see it's still modifying code in the legacy |
No it modifies both JSON and SQL (Though the JSON is obviously superfluous by now, but adding an extra commit just to remove it is also superfluous so pblbll) |
Maybe there's been a misunderstanding, I am asking you to not modify the legacy JSON library file. This file should not have feature code added to it at all. |
Yup, I misunderstood what you meant ^^; |
@@ -19,6 +19,7 @@ class MissingRegistry: | |||
library: Library | |||
files_fixed_count: int = 0 | |||
missing_files: list[Entry] = field(default_factory=list) | |||
library_file_cache: set[Path] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Toby222 Any updates on this? |
No, I got distracted by book releases and forgot until now :^) |
Cache library files instead of rewalking library for every missing entry
Improved PR of #611 that also improves performance for sqlite
Fixes #610
Only a rudimentary fix that could probably be improved by putting the cache somewhere more sensible but this works:tm: