Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix -o flag not working if path has whitespace around it #670

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

python357-1
Copy link
Collaborator

Close #669

@python357-1 python357-1 added Type: Bug Something isn't working as intended Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed labels Dec 24, 2024
@CyanVoxel
Copy link
Member

(macOS) This seems to fix trailing whitespace for me but oddly not leading whitespace: "args": ["-o", " ~/Files/Example 2"]

2024-12-23 23:59:54 [error    ] Path does not exist.           open_path=~/Files/Example 2

@python357-1
Copy link
Collaborator Author

apparently strip() does not do what i thought, dont know how it was working for me. should be fixed now

@CyanVoxel
Copy link
Member

CyanVoxel commented Dec 24, 2024

Confirmed working on Windows, however it still doesn't like leading whitespace on macOS? I feel it's not a strip issue, and strip is supposed to remove leading and trailing whitespace... In the previous log it even shows the stripped output: open_path=~/Files/Example 2

Maybe it's not resolving the home path for some reason? I'll test this some more...

Edit: Yeah it definitely works on absolute paths with both leading and trailing whitespace, even with strip():
"args": ["-o", " /Users/cyanvoxel/Files/Example 2 "]
Just not with ~ for some reason...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed Type: Bug Something isn't working as intended
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

[Bug]: "Open" flag does not work if path has whitespace around it
2 participants