Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement parent tag search #673

Merged
merged 7 commits into from
Jan 1, 2025

Conversation

Computerdores
Copy link
Collaborator

Searching for a tag now includes entries that are only tagged with child tags of the tag. A search for Nintendo would therefore also include entries that only have the tag Mario or Luigi (assuming that Nintendo is a parent tag of Mario and Luigi).

Close #661.

@Computerdores Computerdores added Type: Enhancement New feature or request Priority: High An important issue requiring attention TagStudio: Search The TagStudio search engine Status: Review Needed A review of this is needed labels Dec 28, 2024
@Computerdores Computerdores requested review from python357-1 and CyanVoxel and removed request for python357-1 December 28, 2024 16:32
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Dec 28, 2024
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to function as it's supposed to! The query times can get quite high for some larger libraries and tag sets (16+ seconds for me), but I suppose that's the nature of a non-indexed recursive search like this?

tagstudio/src/core/library/alchemy/visitors.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@python357-1 python357-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for merging but we should probably take a look at the performance when we can, preferably before release. Cyan is probably at the higher end in terms of tags in a library but if a user gets search times near 16 seconds, they will probably think something is wrong.

@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Dec 29, 2024
@CyanVoxel CyanVoxel merged commit 7b672e0 into TagStudioDev:main Jan 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention Status: Mergeable The code is ready to be merged TagStudio: Search The TagStudio search engine Type: Enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Parity/Feature Request]: Parent Tag Searching on SQL
3 participants