-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement parent tag search #673
feat: implement parent tag search #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to function as it's supposed to! The query times can get quite high for some larger libraries and tag sets (16+ seconds for me), but I suppose that's the nature of a non-indexed recursive search like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for merging but we should probably take a look at the performance when we can, preferably before release. Cyan is probably at the higher end in terms of tags in a library but if a user gets search times near 16 seconds, they will probably think something is wrong.
…clude subquery" This reverts commit 2615e7d.
Searching for a tag now includes entries that are only tagged with child tags of the tag. A search for
Nintendo
would therefore also include entries that only have the tagMario
orLuigi
(assuming thatNintendo
is a parent tag ofMario
andLuigi
).Close #661.