fix: replace calls to translate_qobject with translate_formatted inside TagWidget (Fix #733)
#735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Priority: Critical
|
This indeed fixes #733 ! 🥳 |
|
it also breaks being able to change the language without restarting... |
That will need to be a separate issue then, since the resource leak caused by |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #733 by replacing calls to
translate_qobjectwithtranslate_formattedinside theTagWidgetclass, as for an unknown reason this seems to cause the application to progressively slow down as more TagWidgets are created and removed over time, and also seemingly causes a memory leak.The
translate_qobjectissue should be investigated further, however for now this fix should hopefully address the specific issue raised in #733. I've also included a couple small fixes and tweaks to nearby code that I discovered while tracking this down.