-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning during svelte kit build #23
Comments
Same problem here.
|
True, still works. |
svelte-paginate doesn't appear to be written in CJS, but also doesn't appear to be a valid ES module (i.e. it doesn't have "type": "module" or an .mjs extension for the entry point). Please contact the package author to fix. |
I solved this simply by adding "type":"module" in package.json of svelte-paginate in node_modules. I have made PR for this at #27 |
Make sense, @bas-baskara. It is just important to share that by doing this, we're globally changing the default behavior from ESModules to CommonJS. |
@bas-baskara adding I also had to add
Based on this discussion JustinVoitel/svelte-hero-icons#18 If others also have this issue, maybe it can be added to your PR @bas-baskara. |
@jarmitage Yes thank you, I added your suggestion and also typescript support into my PR because I need it in my project too. |
Fixed in |
If you will try to use component in svelte kit you will get message:
Probably it should be migrated to new packaging system presented in kit - https://kit.svelte.dev/docs#packaging
The text was updated successfully, but these errors were encountered: