Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links should update when number of pages changes #13

Merged
merged 3 commits into from
Sep 3, 2016

Conversation

callumacrae
Copy link
Contributor

@callumacrae callumacrae commented Sep 1, 2016

My current workaround is to run this._directives[0].update(this.fullLangs), but that seems like something I shouldn't do.

@TahaSh TahaSh merged commit e6b0e3c into TahaSh:master Sep 3, 2016
TahaSh added a commit that referenced this pull request Sep 3, 2016
@callumacrae callumacrae deleted the list-not-updating branch September 3, 2016 16:37
@callumacrae
Copy link
Contributor Author

Was this released as 2.1.2 or was that before? Bit confused by the commit log.

@TahaSh
Copy link
Owner

TahaSh commented Sep 5, 2016

Hey @callumacrae! First, I really want to thank you for your contribution and taking the time to submit this PR. And yeah, you're right, it's a little bit confusing :).

Actually, before your PR, the version was 2.1.1, but dist/vue-paginate.js wasn't updated, only package.json was. So, you'll notice that dist/vue-paginate.js was updated directly from 2.1.0 to 2.1.2.

Also, ignore these two commits if they're what's causing the confusion: Fix limited links update bug and Revert "Fix limited links update bug". I just pushed a commit then reverted it back to include/merge your commits instead ;).

I'm sorry for this confusion. I hope it's clearer now. And thanks again for your contribution, I really appreciate it :).

@callumacrae
Copy link
Contributor Author

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants