-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlayerCtl refactor, add TauonQueueItem class and start using TauonPlaylist too #1311
Conversation
…track(), Pctl console.print() to logging, fix requests timeout
…nstead of self, use new classes for Playlists/Queues, type fixes
… hide_title as bool
In my experience pickeling classes is a bad idea. Better to save the dict |
…ently supported versions
Would welcome input on the last remaining TODO items. I suppose the slots are the least important item as we can always easily add them later without a migration(?). Currently, we have
I particularly do not like TauonPlaylist having a playlist_ids (renamed from the previous |
…use min() and max() instead of if, sort things, linter changes
This started as an attempt to migrate PlayerCtl into a separate file, which was a complete failure and I decided to instead type it completely and refactor things a little - which turns out needed to be a lot of refactoring, as playlists and queues, which I wanted typed, are used everywhere.
t_main
to tabs, the entire Python codebase is now using tabs for indentationt_draw
too for Gtk - Drop all Gdk/Gtk libs down to 3.0 due to Migrate fromlibayatana-appindicator
/libappindicator-gtk3
toorg.kde.StatusNotifierItem
#1316sg()
is nowget_track_in_playlist()
g()
is nowget_track()
QUE
is nowtrack_queue
hide_title
is now bool instead of 0/1 intTauonQueueItem
and refactoredt_main
for it, also started using the earlier-addedTauonPlaylist
class after a refactorconsole.print()
tologging
module inPlayerCtl
pctl
) instead of using aself
reference - this is correct, right?tryint()
fix from earlier broke it completely, fix it for real this time, also moved it to ExtraTODO:
TauonQueueItem
orTauonPlaylist
should not be changed, so we don't have to write another migration later