Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix song skipping in repeat mode, fix localization issues, typing and logging fixes #1321

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

C0rn3j
Copy link
Collaborator

@C0rn3j C0rn3j commented Nov 30, 2024

  • Fixes Looping a song in a playlist randomly skips to the next song #1320
    There is a race condition in Phazor module where remaining time will randomly end up being in the negatives.
    That manages to fail an if block including a and 0 < remain < 5.5 rule, and proceeds to an if block that runs PlayerCtl.advance() if pctl.commit evaluates as true.
    I am not sure if this issue should not be fixed in some other way better, but the hotfix of adding the repeat check works: if pctl.commit and subcommand != "repeat"
  • Phazor now uses logging instead of the special gui console class
  • Fix logging the file extension when filename had dots in it
  • More typing fixes, Tauon is also now marked as being Typed - https://typing.readthedocs.io/en/latest/spec/distributing.html#packaging-typed-libraries
  • Fix evaluation of Path existing in phazor
  • Fix get_phazor_path() which was returning str instead of Path
  • Fix pathing in compile_translations.py
  • compile_translations.py now outputs to src/tauon/local, .po files were not touched, but they can be moved too to unify things. pyproject.toml now packages *.mo files in locale, this fixes localization.
  • Fairly simplify the localization block for t_main

@C0rn3j C0rn3j changed the title Fix song skipping in repeat mode Fix song skipping in repeat mode, typing fixes Dec 2, 2024
@C0rn3j C0rn3j changed the title Fix song skipping in repeat mode, typing fixes Fix song skipping in repeat mode, typing and logging fixes Dec 2, 2024
@C0rn3j C0rn3j changed the title Fix song skipping in repeat mode, typing and logging fixes Fix song skipping in repeat mode, fix localization issues, typing and logging fixes Dec 2, 2024
@Taiko2k Taiko2k merged commit 1e177f4 into Taiko2k:master Dec 2, 2024
1 check passed
@C0rn3j C0rn3j deleted the fixskip branch December 6, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looping a song in a playlist randomly skips to the next song
2 participants