fix(QTDI-763) issue to enable Tacokit #945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
undx
reviewed
Nov 7, 2024
| @@ -79,7 +80,13 @@ private Path fromStudioConfiguration() { | |||
| // check if we are in the studio process if so just grab the studio config | |||
| final String m2Repo = System.getProperty(STUDIO_MVN_REPOSITORY); | |||
| if (!"global".equals(m2Repo)) { | |||
| return handler.get(Paths.get(System.getProperty("osgi.configuration.area", ""), M2_REPOSITORY).toString()); | |||
| String osgi = System.getProperty("osgi.configuration.area", ""); | |||
There was a problem hiding this comment.
Suggested change
| String osgi = System.getProperty("osgi.configuration.area", ""); | |
| final String osgi = System.getProperty("osgi.configuration.area", ""); |
...in/java/org/talend/sdk/component/runtime/manager/service/MavenRepositoryDefaultResolver.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
undx
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent - https://qlik-dev.atlassian.net/browse/QTDI-763
Task - https://qlik-dev.atlassian.net/browse/QTDI-835
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?