feat(cmf): add common expressions #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
…nd/ui into jmfrancois/feat/cmf/add-expressions
Collaborator
Collaborator
Collaborator
nicomaligne
reviewed
Feb 19, 2018
| ); | ||
| } | ||
|
|
||
| export default curry(getInState); |
Contributor
There was a problem hiding this comment.
This super selectors seems odd and a little bit complex.
I have imagined selectors to be more precise (collectionSelectors, componentSelectors etc).
Not a big fan of this.
Contributor
Author
There was a problem hiding this comment.
The first version was written this way and we add exactly the same code with just 'collections' and 'components' difference.
Contributor
There was a problem hiding this comment.
Don't you think immutable.js is and odd name for a file ?
It can be misleading and confusing with the library immutable.
nicomaligne
suggested changes
Feb 19, 2018
| ); | ||
| } | ||
|
|
||
| export default curry(getInState); |
Contributor
There was a problem hiding this comment.
Don't you think immutable.js is and odd name for a file ?
It can be misleading and confusing with the library immutable.
…nd/ui into jmfrancois/feat/cmf/add-expressions
Collaborator
frassinier
approved these changes
Feb 20, 2018
Collaborator
nicomaligne
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
We have no common expressions related to cmf so we must write code
What is the chosen solution to this problem?
provide default expressions:
TODO: Wait for #1055 to register in api.registerInternals();
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change