-
Notifications
You must be signed in to change notification settings - Fork 53
fix: move out from sass #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move out from sass #5668
Conversation
🦋 Changeset detectedLatest commit: 68db1cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Storybook for this PR deployed on this github page |
Gbacc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's impressive
I don't see anything strange 👍
What is the problem this PR is trying to solve?
sass is heavy and do not follow semver. Our sass is based on the dead bootstrap 3.
What is the chosen solution to this problem?
It's time to move out from it.
The first step is to simply leverage the script I did https://gist.github.com/jmfrancois/16b52b313d35eef589fa2935431d4b70.
Put it in each packages and run it. It call sass and so transforms all files into the corresponding css file.
Note also you have the following typescript error:
You just have to add the following into the existing d.ts file where you have the one for sass:
Please check if the PR fulfills these requirements
yarn changesetto a request a release from the CI if wanted.[ ] This PR introduces a breaking change