Handle missing database #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @steveh, thanks for this great Pull Request ! |
|
Thanks @JonathanTron! I see that you released v0.9.16 which has this PR in the release notes, but it doesn't seem to actually be included in that release? v0.9.16...master |
|
@steveh You're right, I've messed up this release somehow... I'm fixing it and will release 0.9.17. Thanks for catching it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes sequel-rails behave a bit more like ActiveRecord.
db:setupshould be more resilient in that it won't fail to drop a database that doesn't exist.Certain combinations of database.yml, ENV["DATABASE_URL"] and JDBC will now succeed when the port defaults to zero.