Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: silence logger for sequel session store #171

Conversation

mjc-gh
Copy link

@mjc-gh mjc-gh commented Mar 10, 2019

This PR silences the logger when reading and writing sessions to the database. This mimics behavior found in the ActiveRecord::SessionStore class.

Not sure how to best test this. Any suggestions?

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@JonathanTron
Copy link
Member

Hi @mjc-gh, thanks again for this new PR.

About testing it, you can probably do it in an integration test, changing the Sequel logger to output to a StringIO and adding your expectation on that after calling the code to exercise.

@mjc-gh
Copy link
Author

mjc-gh commented Mar 11, 2019

@JonathanTron sounds good! I'll update this PR in the next day or two and get those specs in place. Thanks!

@gencer
Copy link

gencer commented Sep 13, 2019

@JonathanTron, This should be merged because it exposes session data to the logs.

/cc @mjc-gh any update?

@JonathanTron JonathanTron merged commit 6459add into TalentBox:master Sep 16, 2019
@JonathanTron
Copy link
Member

Thanks @mjc-gh for the PR and @gencer for the push ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants