Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color() method deprecation warning #196

Conversation

rwojnarowski
Copy link

Hello, there is a deprecation warning in the latest rails - Rails 7.1 Beta 1

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. 
Use an option hash instead (eg. `color("my text", :red, bold: true)`). 
(called from sql at /usr/local/bundle/bundler/gems/sequel-rails-6ecf2114b606/lib/sequel_rails/railties/log_subscriber.rb:50)

This pr updates code to get rid of deprecation message. Works also with older versions of Rails, i've tested it with 7.0.8

Deprecation message was caused because of change in implementation of method color in ActiveSupport

  • Method color(text, color, bold = false) before - link
  • Method color(text, color, mode_options = {}) now - link

@JonathanTron
Copy link
Member

@rwojnarowski thanks for the PR, I'll review and then merge it.

@JonathanTron JonathanTron merged commit c9acf99 into TalentBox:master Sep 14, 2023
@firstsano
Copy link

firstsano commented Oct 17, 2023

Hello, are there any releases planned yet? We'd really like to have that fix 👍

@JonathanTron
Copy link
Member

@firstsano Yes, I'll try to release a version with this fix tomorrow.

@JonathanTron
Copy link
Member

@firstsano Here you go, v1.2.1 released

@firstsano
Copy link

Thank you! 🎉 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants