provide an after_connect configuration option to run a Proc immadiately ... #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly after connection is made
JonathanTron
added a commit
that referenced
this pull request
Sep 17, 2013
provide an after_connect configuration option to run a Proc immadiately ...
| ::Sequel.connect config['url'], config | ||
| else | ||
| ::Sequel.connect config | ||
| end | ||
|
|
||
| callback = app.config.sequel.after_connect |
There was a problem hiding this comment.
Why not just use configuration instead of the app.config mess?
There was a problem hiding this comment.
Indeed, it should simplify the code. Thanks for the code review!
There was a problem hiding this comment.
Sorry, I forgot I've changed how the Configuration is structured after having merged this, there is no such thing anymore in the code.
Thanks anyway for reviewing it.
There was a problem hiding this comment.
You're welcome; just taking a peek at what changed before upgrading my apps :)
And sorry, my bad, if I'd have checked the current code I'd have noticed you fixed it already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...after connection is made