-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dumping the schema even if there aren't any migrations to run. #53
Conversation
Thanks, this is a great refactor and new functionality. Could you check the specs failures and see if you can fix them? |
Yeah, I'll take care of that. Travis runs a lot more tests than I'm configured to run locally. |
@JonathanTron Any tips on getting the JRuby 1.8 tests to run locally? I tried copying over the ci Gemfile for it, but I must be missing the correct version of rspec or something. I'm seeing:
|
Well, I audited each change to work out what wasn't 1.8 compatible. So that's fixed, but it'd be helpful to understand how I should be running those specs locally. |
@nirvdrum thanks for the fix, here's how you can run the spec under JRuby 1.8 mode: SEQUEL="~> 3.28.0" BUNDLE_GEMFILE=ci/rails-3.2.gemfile jruby --1.8 -S bundle
SEQUEL="~> 3.28.0" BUNDLE_GEMFILE=ci/rails-3.2.gemfile jruby --1.8 -S rake spec adapt the |
Allow dumping the schema even if there aren't any migrations to run.
Thanks. Just to be sure though, what version of rspec should be used? It's not specified in the Gemfile. |
It should work with any RSpec version "~> 2.7.0" (it's defined in the gemspec, which is used by the Gemfile(s)) |
Gotcha. I think because I wasn't running through bundle exec, it was just picking up whatever I had. And my attempt at copying over the Gemfile made the gemspec part not work. Thanks again. |
You're welcome, thanks for taking the time to report your experience and provide fixes. |
No description provided.