Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dumping the schema even if there aren't any migrations to run. #53

Merged
merged 4 commits into from
Oct 6, 2013

Conversation

nirvdrum
Copy link

@nirvdrum nirvdrum commented Oct 5, 2013

No description provided.

@JonathanTron
Copy link
Member

Thanks, this is a great refactor and new functionality. Could you check the specs failures and see if you can fix them?

@nirvdrum
Copy link
Author

nirvdrum commented Oct 5, 2013

Yeah, I'll take care of that. Travis runs a lot more tests than I'm configured to run locally.

@nirvdrum
Copy link
Author

nirvdrum commented Oct 5, 2013

@JonathanTron Any tips on getting the JRuby 1.8 tests to run locally? I tried copying over the ci Gemfile for it, but I must be missing the correct version of rspec or something. I'm seeing:

NameError: uninitialized constant Combustion
    const_missing at org/jruby/RubyModule.java:2684
    const_missing at /home/nirvdrum/.rbenv/versions/jruby-1.7.5/lib/ruby/gems/shared/gems/rspec-core-2.14.5/lib/rspec/core/backward_compatibility.rb:14

@nirvdrum
Copy link
Author

nirvdrum commented Oct 6, 2013

Well, I audited each change to work out what wasn't 1.8 compatible. So that's fixed, but it'd be helpful to understand how I should be running those specs locally.

@JonathanTron
Copy link
Member

@nirvdrum thanks for the fix, here's how you can run the spec under JRuby 1.8 mode:

SEQUEL="~> 3.28.0" BUNDLE_GEMFILE=ci/rails-3.2.gemfile jruby --1.8 -S bundle
SEQUEL="~> 3.28.0" BUNDLE_GEMFILE=ci/rails-3.2.gemfile jruby --1.8 -S rake spec

adapt the SEQUEL environment variable to match a specific version if you want. By default rake spec will run the spec for Postgres only.

JonathanTron added a commit that referenced this pull request Oct 6, 2013
Allow dumping the schema even if there aren't any migrations to run.
@JonathanTron JonathanTron merged commit 6c3fce6 into TalentBox:master Oct 6, 2013
@nirvdrum
Copy link
Author

nirvdrum commented Oct 6, 2013

Thanks. Just to be sure though, what version of rspec should be used? It's not specified in the Gemfile.

@JonathanTron
Copy link
Member

It should work with any RSpec version "~> 2.7.0" (it's defined in the gemspec, which is used by the Gemfile(s))

@nirvdrum
Copy link
Author

nirvdrum commented Oct 6, 2013

Gotcha. I think because I wasn't running through bundle exec, it was just picking up whatever I had. And my attempt at copying over the Gemfile made the gemspec part not work. Thanks again.

@JonathanTron
Copy link
Member

You're welcome, thanks for taking the time to report your experience and provide fixes.

JonathanTron added a commit that referenced this pull request Nov 16, 2013
This is to ensure we have access to special variables ($?, etc.) via
their english name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants