chore: cleanup hook #1033
Merged
chore: cleanup hook #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidg
approved these changes
Aug 23, 2023
chidg
added a commit
that referenced
this pull request
Aug 29, 2023
* chore: kill mystical background acolyte * chore: changeset * chore: cleanup hook (#1033) --------- Co-authored-by: Kheops <26880866+0xKheops@users.noreply.github.com>
chidg
added a commit
that referenced
this pull request
Sep 14, 2023
* feat: add migrations store * feat: run migrations on startup when installed or updated * refactor: tidy up legacy migrations * chore: changed name to runner and tidied up * refactor: move migrations code to libs * feat: wip: multiple mnemonic seed store mostly works * feat: fix problem migrating mnemonic when changing password * fix: give password to migrations in context allowing seed access during migration * fix: migration runner tests * fix: layout dead click zone at bottom * feat: accordion className * feat: mnemonics page * feat: accounts iconstack * wip: manage recovery phrases ui * feat: delete mnemonic * feat: save mnemonic when importing account(s) * feat: backup only from recovery phrases page * fix: migration mnemonic find error * fix: attach accounts to mnemonic on onboarding * fix: import without derivation path * chore: set package version * feat: disabled item style in context menu * feat: backup mnemonic * Onboarding v5 (#993) * refactor: onboarding welcome page * feat: add progress bar to onboarding and update password input stage * feat: wip: cleanup privacy onboarding page * chore: replace some styled components with tailwind classes * chore: remove more styled components * refactor: reduce background opacity as onboard stages progress * fix: improve layout of privacy page * refactor: remove unused * feat: add pictures to onboarding background * fix: improve performance of mystical background * feat: add do it later button to onboard progress bar * refactor: remove account related tasks from onboard handler * refactor: update handlers to allow onboarding without account creation * feat: handle case where user navigates back in onboarding after setting pw * feat: complete basic entry menu UI for add account flow * chore: tidy up and ensure cross browser compat * feat: add onboarding success page * chore: remove onboard status messages and rely on app state subscription only * chore: tidy up * feat: update fullscreen sidebar to handle no accounts * feat: update popup to handle no accounts * feat: add nice empty state message to fullscreen portfolio * chore: tidy up * feat: use new account selection menu for account creation in dashboard * feat: all create new account via onboarding * feat: allow create new account by json import in onboarding * feat: allow account creation via import seed phrase in onboarding * feat: allow import of ledger account in onboarding * fix: remove @ui react-app-env types rule * fix: prevent onboard background animation pausing on hover * fix: minor UI improvements on add account screen * fix: failing tests * fix: checkPassword if pw not hashed (v1) (#1029) * feat: fine tune backup & delete modals * feat: icon to reveal mnemonic * fix: backup modal adjustments * fix: backup modal layout shift * fix: unused imports * Remove mystical acolyte (#1032) * chore: kill mystical background acolyte * chore: changeset * chore: cleanup hook (#1033) --------- Co-authored-by: Kheops <26880866+0xKheops@users.noreply.github.com> * feat: show mnemonic before creating account (#1036) * feat: set PV certifier & sort mnemonics/accounts * fix: eslint * fix: import from PK * wip: show mnemonic before account create * feat: new mnemonic for new account * feat: obfuscate account creation msg * feat: allow removal of root account * fix: expotable origins * fix: style * feat: can't mark as backed up until revealed * fix: number color * feat: copied text * feat: account tooltip * fix: hasFunds false by default * chore: remove account tooltip * fix: multi account import from mnemonic * chore: cleanup * refactor: performance improvement Co-authored-by: Chid Gilovitz <chid@talisman.xyz> * fix: suggestion * refactor: mnemonic fetch * fix: tests (wip) * fix: tests * fix: signing tests --------- Co-authored-by: Chid Gilovitz <chid@talisman.xyz> * More onboarding improvements (#1047) * fix: prefer Balances rather than Balance[] on account import * chore: rename AccountCreate -> AccountAdd for consistency * feat: add watched account as onboarding account creation option * fix: yeet Kusama * refactor: tidy up * refactor: add AccountAddWrapper to unify onboarding account add component UI * feat: allow onboarding with qr code account * chore: turn off i18n debug * feat: prevent creation of account in onboarding when user is not logged in * fix: improve copy on onboarding success page * fix: navigation after password in onboarding * fix: prevent flicker on fullscreen portfolio when no accounts * fix: broken link on watched account from portfolio no accounts empty state * feat: enable DCent account creation in onboarding * feat: add nice empty state page to popup when no accounts * fix: pr review issues * fix: display add account menu at top of page rather than centred in fullscreen view * fix: revert part of last * feat: custom derivation path - 2nd attempt (#1049) * feat: form container normal casing for errors * feat: import account with custom derivation path * feat: derivation path in new account screen * fix: wording * feat: derivation path validation * chore: cleanup * chore: cleanup * chore: cleanup * feat: missing i18n * fix: useTranslation usage * fix: review fixes & predict next dp * fix: derivation path validation * fix derivation path validation * More mnemonic store fixes (#1050) * refactor: changed name of seedPhraseStore to mnemonicsStore * fix: remove "Vault" as source value for stored mnemonic * refactor: move mnemonic messages from accounts handler * chore: changed some instances of "seed" to "mnemonic" or "recovery phrase" * fix: remove references to legacy verifier certificate store * fix: more merge updates * fix: more mnemonic store tweaks * chore: rename seed -> suri in account creation method * feat: use mnemonic creation modal to allow creation of mnemonic for vault verifier certificate * feat: ensure mnemonic generate for vault verifier certificate works properly * refactor: migrate account types * refactor: replace "hardware" with "ledger" in account creation * chore: tidy up * fix: typo * fix: flicker in popup load showing empty state * chore: changeset * fix: mnemonic backup behaviour for new settings * chore: yeet styled components (#1072) * chore: remove dead code * fix: memoized background * chore: onboard layout without SC * feat: account pill without SC * chore: yeet styled components * chore: adjustments & changeset * fix: fade in duration * Make migrate password mandatory (#1075) * chore: prevent ignoring password upgrade * refactor: improve mandatory password migration ui behaviour * fix: enable logging in with legacy root account * fix: use recoil atom for "should migrate password" state * fix: include support link on migrate password error boundary * fix: copy and buttons on manage accounts screen --------- Co-authored-by: Kheops <26880866+0xKheops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed the hook wasn't cleaned up
wanted to check something about easings which led me to do it, so here's the PR :)
(this targets your PR)