feat: TAO staking #1682

UrbanWill · 2024-11-03T12:20:05Z

Description

Implements TAO staking

⚠️ Warning

Depends on https://github.com/TalismanSociety/talisman-config/pull/7
Add TAOSTATS_API_KEY to .env

Techical

Renamed folder/components from Nomination pool bond specific to generic bonding names, eg: NomPoolBondModal -> BondModal
Created bittensor and nompool folders inside a new hooks folder for organization purposes
Created useGetStakeInfo and useGetUnbondInfo hooks to support the wizard hooks. These hooks are responsible for returning all the information that is specific to an Asset that is being staked/unbonded.
Removed fake fee estimate, use a fee estimation that defaults to minJoinBond if the input amount is 0 or less than min for that pool, disable form submission if planks is < 0n

TODO's

Hooks for fetching TAO delegator data
Pop up UI for selecting delegator
Dashboard UI for selecting a delegator
Refactor dashboard asset view to display the amount stake per Delegator
Hook to track the block number when the user unstaked the total balance from a delegator (used for 360 blocks cooldown)

🖼️ Screenshots:

Screen.Recording.2024-11-14.at.20.33.17.mov

… by chain id

…r a given asset

…ndInfo

…uld not

fetch payload with 0n plancks and invalidate form if pancks is < 0n

…ing actions

alecdwm

👌

chidg · 2024-11-19T11:26:33Z

Looking great, a few small things to add re: error handling of fetch requests.

When no TAOSTATS_API_KEY is configured, or else the fetchBittensorInfiniteValidators function fails for some reason, it would be good to display a nice message like "Unable to fetch validators" rather than just an empty screen

apps/extension/src/ui/domains/Staking/hooks/bittensor/useGetBittensorSupportedDelegates.ts

apps/extension/src/ui/domains/Staking/hooks/bittensor/useGetBittensorValidator.ts

apps/extension/src/ui/domains/Staking/hooks/bittensor/useGetBittensorInfiniteValidators.ts

0xKheops

some minor things, please check below.

another that didnt fit to a particular part of the code is that i see bittensor staking related hooks being called a lot for no reason, especially in AssetDetails
calling any of them loads bittensor sapi object which downloads the full metadata.
Unless a bittensor balance is detected, it would be nice to make sure those hooks do nothing.
Note: at this time even if if bittensor is disabled in settings, they will fetch metadata and execute all the logic

apps/extension/src/ui/domains/Staking/hooks/bittensor/useCombineBittensorStakeInfo.ts

apps/extension/src/ui/domains/Staking/Bond/BondForm.tsx

apps/extension/src/ui/domains/Staking/Bond/useBondButton.ts

apps/extension/src/ui/domains/Staking/Bond/useBondWizard.ts

apps/extension/src/ui/domains/Staking/shared/BondPoolName.tsx

apps/extension/src/ui/domains/Staking/shared/StakingFeeEstimate.tsx

apps/extension/src/ui/domains/Staking/shared/StakingUnbondingPeriod.tsx

apps/extension/src/ui/domains/Transactions/TxProgress.tsx

packages/util/src/formatTokenDecimals.ts

chidg

Few more comments, apologies - these got lost in vs code PR review process somewhere

apps/extension/src/ui/domains/Staking/Bond/BondForm.tsx

apps/extension/src/ui/domains/Staking/shared/BondPoolName.tsx

apps/extension/src/ui/domains/Staking/shared/useGetLatestBlockNumber.ts

…rror

…ao bal is 0

…nents

…button return

0xKheops

Sorry, one more change needed in TxProgress :)

0xKheops · 2024-11-22T02:07:08Z

apps/extension/src/ui/domains/Transactions/TxProgress.tsx

+  networkIdOrHash,
+  onClose,
+  className,
+  onSuccess,


Sorry i didnt dig this thing enough last time.
It feels like success detection shouldnt originate from here, which is a UI component that is meant to support both EVM and substrate.

Option 1 : use useTransaction(hash) from useUnbondWizard() to detect success from there, without needing any callbacks, and rollback all changes to this component
Option 2 : move the success check from TxProgressSubstrate up to TxProgress, so it can support both substrate and evm

Preference for option 1 though

UrbanWill added 24 commits October 31, 2024 14:56

feat: display stake button for TAO token

95a235f

feat: created bittensor validator hook, dinamically display pool info…

f9cf9dd

… by chain id

feat: useGetStakingInfo hook, and auxiliary hooks to fetch staking fo…

01e8f44

…r a given asset

feat: updated NoomPoolBondWizard, updated component types

23415a9

feat: hooks for bittensor hotkeys and validators

7a2aaf7

feat: display bittensor validator name and unbound button

c3c070b

feat: hooks for fetching nomPooldata, consolidated data in useGetUnbo…

41eb99c

…ndInfo

feat: unbond TAO, totalStaked and unbondPayload hooks

7111f55

fix: poolname, unbond btn and loading sekeleton displayed when it sho…

c092184

…uld not

fix: staking TAO with remark

d8f8ab3

chore: added taostats api key to env and webpack

d0611e8

feat: unbond TAO, display tao unbond info

580eec6

feat: useGetBittensorMinJoinBond

9821a16

refactor: conslidated data in useGetStakeInfo hook

27dd3b3

fix: max button not working before input,

3adc0d6

fetch payload with 0n plancks and invalidate form if pancks is < 0n

chore: tidy up useGetUnbondInfo

d97dbe3

feat: added hooks to fetch and calculated if can stake bittensor

952b4eb

feat: display stake warning message and tooltip

0aeec5c

chore: renamed NomPoolBond folder and items to "Bond"

b05ddbc

chore: renamed NomPoolUnboond folder and items to "Unbond"

b942d30

chore: created hooks folder, organized bittensor and nomPools hooks

8f8b160

fix: bittensor cooldown when switching accounts back and forth

1efd7b8

chore: added comment

221848b

chore: renamed component name to be generic to bonds

7249328

UrbanWill requested a review from 0xKheops November 8, 2024 01:49

UrbanWill added 5 commits November 8, 2024 12:42

feat: added BondSelectDrawer for popup UI

31992e9

feat: added BittensorBondSelectDrawer

46ebf8e

feat: hooks to fetch and merged Bittensor delegators data

f151740

feat: bondSelectDrawer, bond skeleton option

2c2e1e7

feat: sort delegators

4fc6fe3

UrbanWill added 3 commits November 18, 2024 16:57

chore: pr review change requests, added horizontal scrolling for sort…

7d167af

…ing actions

chore: bond row label, bond form form grid spacing

620b19b

feat: added taostats proxy api

fedcad7

alecdwm previously approved these changes Nov 19, 2024

View reviewed changes

chidg reviewed Nov 19, 2024

View reviewed changes

apps/extension/src/ui/domains/Staking/hooks/bittensor/useGetBittensorSupportedDelegates.ts Show resolved Hide resolved

chidg reviewed Nov 19, 2024

View reviewed changes

apps/extension/src/ui/domains/Staking/hooks/bittensor/useGetBittensorValidator.ts Show resolved Hide resolved

chidg reviewed Nov 19, 2024

View reviewed changes

apps/extension/src/ui/domains/Staking/hooks/bittensor/useGetBittensorInfiniteValidators.ts Outdated Show resolved Hide resolved

0xKheops requested changes Nov 20, 2024

View reviewed changes

chidg requested changes Nov 20, 2024

View reviewed changes

apps/extension/src/ui/domains/Staking/Bond/BondForm.tsx Outdated Show resolved Hide resolved

apps/extension/src/ui/domains/Staking/shared/BondPoolName.tsx Outdated Show resolved Hide resolved

apps/extension/src/ui/domains/Staking/shared/useGetLatestBlockNumber.ts Show resolved Hide resolved

UrbanWill added 4 commits November 20, 2024 16:56

feat: handle missing origin/auth headers

ecc1436

refactor: display UI errors

a5f4a55

refactor: error handling

053706a

refactor: apr error msg, duplicated var assignement, null query key e…

9ba8025

…rror

UrbanWill dismissed alecdwm’s stale review via 9ba8025 November 20, 2024 10:53

UrbanWill added 9 commits November 21, 2024 13:16

perf: memoized values and disabled queries when token is not tao or t…

e0a9e44

…ao bal is 0

chore: memoized variables, fixed transalation, removed eslint comment

23da3e1

refactor: broke down BondPoolName into multiple child components

9a11735

refactor: broke down StakingUnbondingPeriod into multiple child compo…

42e3fb8

…nents

fix: only display error msg in BondOption if there is actually an error

81b733e

refactor: out with formatTokenDecials in planckToTokens

c3bdcd9

refactor: use minJoinBond to get an accurate fake fee estimation

f4a806a

refactor: moved onSuccess ot its opwn useEffect in TxProgressBase

eeff39a

chore: removed mocked remote config

a631e74

UrbanWill requested review from 0xKheops and chidg November 21, 2024 09:33

UrbanWill added 2 commits November 21, 2024 16:58

chore: removed redundant translation, early bittensor delegator name …

ed46dbc

…button return

chore: early bittensor delegator name button return, cath api error

e11a89f

0xKheops requested changes Nov 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: TAO staking #1682

feat: TAO staking #1682

UrbanWill commented Nov 3, 2024 •

edited

Loading

alecdwm left a comment

chidg commented Nov 19, 2024 •

edited

Loading

0xKheops left a comment

chidg left a comment

0xKheops left a comment

0xKheops Nov 22, 2024 •

edited

Loading

feat: TAO staking #1682

Are you sure you want to change the base?

feat: TAO staking #1682

Conversation

UrbanWill commented Nov 3, 2024 • edited Loading

Description

⚠️ Warning

Techical

TODO's

🖼️ Screenshots:

alecdwm left a comment

Choose a reason for hiding this comment

chidg commented Nov 19, 2024 • edited Loading

0xKheops left a comment

Choose a reason for hiding this comment

chidg left a comment

Choose a reason for hiding this comment

0xKheops left a comment

Choose a reason for hiding this comment

0xKheops Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

UrbanWill commented Nov 3, 2024 •

edited

Loading

chidg commented Nov 19, 2024 •

edited

Loading

0xKheops Nov 22, 2024 •

edited

Loading