-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update custom signing UIs #1687
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/node@22.7.9 |
🦋 Changeset(s) detectedThis PR includes changeset(s) for the following changed packages:
Not sure what this means? Click here to learn what changesets are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! couple of nits if you agree
apps/extension/src/ui/domains/Sign/Substrate/decode/SubSignDecodedBatch.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥🥊🥊💥
🥊 POLKADOT VS. THE WORLD: THE TRANSACTION DECODING SHOWDOWN 🥊
Ladiiiiiiiiiiiies and gentlemen,
Welcome to the Talisman Arena! In this corner, standing tall and sleek, is Polkadot, the champion of interoperability, bringing its A-game with unparalleled security and a user friendly transaction signing experience. And in the opposite corner, we have the competition—other blockchains, notorious for their cumbersome transaction flows, cryptic payloads, and user-unfriendly interfaces.
But today, we’re not just spectating; we’re here to witness Polkadot’s ultimate victory in transaction decoding!