Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update custom signing UIs #1687

Merged
merged 49 commits into from
Nov 21, 2024
Merged

feat: update custom signing UIs #1687

merged 49 commits into from
Nov 21, 2024

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Nov 6, 2024

🥊 POLKADOT VS. THE WORLD: THE TRANSACTION DECODING SHOWDOWN 🥊

Ladiiiiiiiiiiiies and gentlemen,

Welcome to the Talisman Arena! In this corner, standing tall and sleek, is Polkadot, the champion of interoperability, bringing its A-game with unparalleled security and a user friendly transaction signing experience. And in the opposite corner, we have the competition—other blockchains, notorious for their cumbersome transaction flows, cryptic payloads, and user-unfriendly interfaces.

But today, we’re not just spectating; we’re here to witness Polkadot’s ultimate victory in transaction decoding!

image

Copy link

socket-security bot commented Nov 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/anylogger-loglevel@1.0.0 None 0 20 kB stijndewitt
npm/anylogger@1.0.11 None 0 44.9 kB stijndewitt
npm/archiver@7.0.1 filesystem +2 863 kB ctalkington
npm/assert@2.1.0 None 0 82.1 kB ljharb
npm/autoprefixer@10.4.20 environment 0 199 kB ai
npm/babel-eslint@10.1.0 Transitive: environment +14 6.26 MB kaicataldo
npm/babel-jest@29.7.0 environment Transitive: filesystem, shell +24 5.74 MB simenb

🚮 Removed packages: npm/@types/node@22.7.9

View full report↗︎

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🦋 Changeset(s) detected

This PR includes changeset(s) for the following changed packages:

"@talismn/balances"
"@talismn/scale"
"@talismn/util"

Not sure what this means? Click here to learn what changesets are.

@0xKheops 0xKheops marked this pull request as ready for review November 19, 2024 06:13
@0xKheops 0xKheops requested a review from chidg November 19, 2024 06:13
chidg
chidg previously approved these changes Nov 21, 2024
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! couple of nits if you agree

Copy link
Member

@alecdwm alecdwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🥊🥊💥

@0xKheops 0xKheops merged commit 89e4533 into dev Nov 21, 2024
6 checks passed
@0xKheops 0xKheops deleted the feat/update-custom-signing-uis branch November 21, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants