fix: improved autolock to only keep wallet unlocked while user is actively interacting with it #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ively interacting with it
alecdwm
force-pushed
the
fix/autolock-improvements
branch
from
123328d
to
f1c72c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are surprised when their wallet never autolocks - but the current behaviour intentionally only autolocks the wallet when all wallet UI has been closed.
This PR changes it that so the the wallet will autolock even if the UI is open (e.g. in a background tab) - provided that the user is not actively interacting with the UI (as measured by keydown / keypress / keyup / mousedown / mouseup / mousemove / touchstart / touchend / touchmove events).
NOTE: The embedded popup retains the old behaviour: the wallet will never lock for as long as the embedded popup is open.