Add new step for easier graphql query #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taluu
reviewed
Jul 1, 2020
mhlsf
force-pushed
the
grahpql-query-support
branch
4 times, most recently
from
62adee7 to
6fd51f3
Compare
mhlsf
force-pushed
the
grahpql-query-support
branch
from
6fd51f3 to
35a910a
Compare
Taluu
reviewed
Jul 20, 2020
Comment on lines
+40
to
+41
| /** @var string */ | ||
| private $graphqlEndpoint; |
There was a problem hiding this comment.
rather than a propoerty, it would be better IMO to have a I create the following graphql request on :graphqlEndpoint:: or something like that
There was a problem hiding this comment.
Yes, but as an graphql endpoint is something that is fixed the same for all graphql request, it is redundant to precise it again in each request in my opinion
mhlsf
force-pushed
the
grahpql-query-support
branch
from
35a910a to
74c59b1
Compare
mhlsf
force-pushed
the
grahpql-query-support
branch
from
74c59b1 to
97ba02f
Compare
mhlsf
force-pushed
the
grahpql-query-support
branch
from
97ba02f to
9c2dcdb
Compare
mhlsf
force-pushed
the
grahpql-query-support
branch
from
9c2dcdb to
07518bc
Compare
|
Had my eyes on this a short while ago, not sure if it is pertinent to have a graphql step to be honest, as a graphql reequest can be sent through a simple http request (with the graphql query as the body). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a step that by default set the method to post and the route for the request to /graphql.
Also Json encode the query into the graphQl wrapper.