Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

Fixed: Тап по событию "пролезал" в модалку события #61

Merged
merged 2 commits into from
Aug 15, 2017
Merged

Fixed: Тап по событию "пролезал" в модалку события #61

merged 2 commits into from
Aug 15, 2017

Conversation

cybri0nix
Copy link
Collaborator

  • Зайти в раздел Главные события
  • Клик (тап) по событию
  • Откроется модалка
  • Затем в ней еще раз срабатывает Тап
  • Заресерчил.

Проблема с react-tap-event-plugin.

zilverline/react-tap-event-plugin#77

Баг еще не исправлен, думаю стоит откатиться на onClick в кнопках, которые открывают модалки

@cybri0nix cybri0nix changed the base branch from master to develop August 15, 2017 19:58
Tamik
Tamik approved these changes Aug 15, 2017
View reviewed changes
Copy link
Owner

@Tamik Tamik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Tamik Tamik merged commit cb349c3 into develop Aug 15, 2017
@cybri0nix cybri0nix deleted the modals-events-bubbling branch August 15, 2017 20:27
@Lunory Lunory assigned Lunory and cybri0nix and unassigned Lunory Aug 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tamik Tamik Tamik approved these changes

Assignees

@cybri0nix cybri0nix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cybri0nix @Tamik @Lunory