Update TS config #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tested the template and wanted to improve the TS config setup to match a bit more what I've did for Vite and Bun templates. A few points:
typeswhich avoid polluting code completions with node globals for an SPA starter. This also match the fact that the dependency is not explicit and the fact that the only real node file, the vite config, is in JS. If this changed to a TS file (I would be in favor), adding@types/nodeand adding back"types": ["vite/client", "node"],would provide a good setup without adding 3 tsconfigs like in VitenoEmitbecause for apps there is no point to emit typesverbatimModuleSyntaxwhich makes tools like esbuild predictable on how to preserve or drop importsuseUnknownInCatchVariablesandnoPropertyAccessFromIndexSignaturebut they can add friction for people not use to them so like in Vite they are not included.