Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-forks-live.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/form-core': patch
---

fix(form-core): prevent runtime errors when using `deleteField`
10 changes: 10 additions & 0 deletions packages/form-core/src/FormApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1642,6 +1642,11 @@ export class FormApi<
for (const field of Object.keys(
this.state.fieldMeta,
) as DeepKeys<TFormData>[]) {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (this.baseStore.state.fieldMetaBase[field] === undefined) {
continue
}

const fieldMeta = this.getFieldMeta(field)
if (!fieldMeta) continue

Expand Down Expand Up @@ -1845,6 +1850,11 @@ export class FormApi<
for (const field of Object.keys(
this.state.fieldMeta,
) as DeepKeys<TFormData>[]) {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (this.baseStore.state.fieldMetaBase[field] === undefined) {
continue
}

const fieldMeta = this.getFieldMeta(field)
if (!fieldMeta) continue

Expand Down
66 changes: 66 additions & 0 deletions packages/react-form/tests/useForm.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -892,4 +892,70 @@ describe('useForm', () => {
await user.click(target)
expect(result).toHaveTextContent('1')
})

it('should not error when using deleteField in edge cases', async () => {
function Comp() {
const form = useForm({
defaultValues: {
firstName: '',
lastName: '',
},
validators: {
onChange: ({ value }) => {
const fields: Record<string, string> = {}

if (value.firstName.length === 0) {
fields.firstName = 'Last Name is required'
}

return { fields }
},
},
})

return (
<form
onSubmit={(e) => {
e.preventDefault()
form.handleSubmit()
}}
>
<h1>Personal Information</h1>
<form.Field
name="firstName"
children={(field) => (
<input
data-testid="input"
value={field.state.value}
onChange={(e) => field.handleChange(e.target.value)}
/>
)}
/>
<form.Field
name="lastName"
children={(field) => (
<input
value={field.state.value}
onChange={(e) => field.handleChange(e.target.value)}
/>
)}
/>
<button
type="button"
data-testid="remove"
onClick={() => form.deleteField('firstName')}
>
remove first name
</button>
</form>
)
}

const { getByTestId } = render(<Comp />)
const removeButton = getByTestId('remove')
const input = getByTestId('input')

await user.type(input, 'a')
await user.click(removeButton)
})
})
Loading