Skip to content

Conversation

PejmanNik
Copy link
Contributor

fix #1764

🎯 Changes

check the dontValidate option in array modifiers before applying validation

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

check the `dontValidate` option in array modifiers before applying validation

fix TanStack#1764
Copy link

changeset-bot bot commented Sep 28, 2025

🦋 Changeset detected

Latest commit: 73b2953

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@tanstack/form-core Patch
@tanstack/angular-form Patch
@tanstack/form-devtools Patch
@tanstack/lit-form Patch
@tanstack/react-form Patch
@tanstack/solid-form Patch
@tanstack/svelte-form Patch
@tanstack/vue-form Patch
@tanstack/react-form-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@PejmanNik
Copy link
Contributor Author

I couldn't find a single test that checks the dontValidate , should I create a parameterized test for it? What is your plan?

Copy link

nx-cloud bot commented Sep 28, 2025

View your CI Pipeline Execution ↗ for commit 73b2953

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 18s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 24s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-11 07:31:50 UTC

Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not sure why codecov is not tracking this, but either way, unit tests for meta options would be great!

Copy link

pkg-pr-new bot commented Sep 28, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1775

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1775

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1775

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1775

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1775

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1775

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1775

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1775

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1775

commit: 73b2953

Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (6892ed0) to head (73b2953).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
+ Coverage   90.35%   90.51%   +0.16%     
==========================================
  Files          38       38              
  Lines        1752     1803      +51     
  Branches      444      466      +22     
==========================================
+ Hits         1583     1632      +49     
- Misses        149      151       +2     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PejmanNik
Copy link
Contributor Author

Thank you, I'll try to create a separate PR for adding tests

@LeCarbonator
Copy link
Contributor

I'll merge later today. Thanks for the PR!

@LeCarbonator
Copy link
Contributor

LeCarbonator commented Oct 11, 2025

later today

so that was a lie ... Sorry about the delay!

@LeCarbonator LeCarbonator changed the title fix(form-core): respect dontValidate option in formApi array modifiers fix(form-core): respect dontValidate option in form array methods Oct 11, 2025
@LeCarbonator LeCarbonator merged commit 33cce81 into TanStack:main Oct 11, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moveFieldValues doesn’t respect UpdateMetaOptions

2 participants