-
-
Notifications
You must be signed in to change notification settings - Fork 580
fix(vue-form): prevent full array re-renders in array mode #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(vue-form): prevent full array re-renders in array mode #1963
Conversation
|
|
View your CI Pipeline Execution ↗ for commit b9e7a3c
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
+ Coverage 90.35% 93.33% +2.97%
==========================================
Files 38 2 -36
Lines 1752 60 -1692
Branches 444 3 -441
==========================================
- Hits 1583 56 -1527
+ Misses 149 4 -145
+ Partials 20 0 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CI is green and coverage is fixed. |
|
Wait, I'm confused - shouldn't this be avoided as-of https://github.com/TanStack/form/releases/tag/%40tanstack%2Fvue-form%401.27.7 ? |
|
I checked the 1.27.7 changes and this does not reintroduce the behavior avoided there. The change in 1.27.7 avoids subscribing to the full field state to prevent unnecessary updates. If there’s a specific concern with multiple useStore subscriptions in Vue, I’m happy to adjust the approach. |
|
I see this mentions Vue but the behavior also happens in react |
Closes #1961
Problem
In the Vue adapter,
useFieldcurrently subscribes to the entire field state via: