Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove first level sleep in tests and use fake timers #809

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Balastrong
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Jul 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f561cc2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally with pnpm test:ci --skip-nx-cache, fingers crossed it works in CI!

@lachlancollins
Copy link
Member

@Balastrong I re-ran the failed CI workflow and it passed (I think the tests were just flaky). Hopefully this PR is a more stable solution!

@lachlancollins lachlancollins merged commit 1eda603 into TanStack:main Jul 2, 2024
2 checks passed
@Balastrong Balastrong deleted the test/remove-sleep branch July 3, 2024 06:02
@Balastrong
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants