Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: force createServerFn usage with getFormData #826

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: force createServerFn usage with getFormData #826

merged 1 commit into from
Jul 8, 2024

Conversation

crutchcorn
Copy link
Member

There was a bug in our TanStack Start adapter that led to headaches. This PR fixes those but introduces a minor breaking change where Start users need to use createServerFn now alongside getFormData

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 8, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7ec9cd2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 7ec9cd2

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@826

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@826

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@826

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@826

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@826

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@826

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@826

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@826

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@826

templates

@crutchcorn crutchcorn merged commit 3b91e6c into main Jul 8, 2024
4 checks passed
@crutchcorn crutchcorn deleted the fix-start-usage branch July 8, 2024 20:05
@bernardarhia bernardarhia mentioned this pull request Sep 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crutchcorn