-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(solid-form): Build ESM, CJS, and source #844
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c25deb2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 91.55% 91.66% +0.11%
==========================================
Files 21 2 -19
Lines 900 36 -864
Branches 206 1 -205
==========================================
- Hits 824 33 -791
+ Misses 71 3 -68
+ Partials 5 0 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
This implements the changes discussed on Corbin's stream with Ryan.
esm
andcjs
builds are now generated again for use in no-build environmentssource
, keeping with Solid ecosystem conventionssource
entrypoint is still.jsx
to make sure that all JSX gets compiled properly